Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(143)

Issue 138950043: Issue 4078: Doc: Use variables rather than instrument definitions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by Trevor Daniels
Modified:
9 years, 8 months ago
Reviewers:
Keith, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4078: Doc: Use variables rather than instrument definitions Using variables for switching character names in vocal music rather than instrument definitions is easier to understand, easier to set up and quicker to type. It also frees up the use of instrument definitions so they may be tailored for better use in instrumental compositions. Remove the mention of \transposition. This is never required in vocal music. Adjust references to match the changes.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -33 lines) Patch
M Documentation/notation/vocal.itely View 1 chunk +22 lines, -33 lines 6 comments Download

Messages

Total messages: 5
Keith
LGTM I was thinking of completing the deprecation of instrumentSwitch, https://codereview.appspot.com/133390043/ unless you want to ...
9 years, 8 months ago (2014-08-31 06:58:47 UTC) #1
dak
On 2014/08/31 06:58:47, Keith wrote: > https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2646 > Documentation/notation/vocal.itely:2646: \set instrumentCueName = "Flute" > This ...
9 years, 8 months ago (2014-08-31 07:14:11 UTC) #2
Trevor Daniels
Thanks Keith. Responses below. Trevor https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2580 Documentation/notation/vocal.itely:2580: kaspar = { On ...
9 years, 8 months ago (2014-08-31 07:58:50 UTC) #3
Keith
still LGTM https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2580 Documentation/notation/vocal.itely:2580: kaspar = { On 2014/08/31 07:58:49, Trevor ...
9 years, 8 months ago (2014-08-31 08:25:53 UTC) #4
Trevor Daniels
9 years, 8 months ago (2014-09-05 11:55:29 UTC) #5
Message was sent while issue was closed.
Pushed to staging as
c0c3cd6ac43112ce392f9559555f723b359580a6
Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b