Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(550)

Issue 13768045: align-interface.cc: Clarify code for empty staves

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Keith
Modified:
10 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

While tentatively evaluating potential line-breaks for planning of page-filling, the old code removed tentatively-empty axis-groups from an array in one function and restored them in another. This patch keeps the array intact.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Proposed, relative to first reverted attempt #

Patch Set 3 : Proposed, relative to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -94 lines) Patch
M lily/align-interface.cc View 1 2 7 chunks +76 lines, -94 lines 0 comments Download

Messages

Total messages: 1
Keith
10 years, 7 months ago (2013-09-25 07:01:17 UTC) #1
https://codereview.appspot.com/13768045/diff/1/lily/align-interface.cc
File lily/align-interface.cc (left):

https://codereview.appspot.com/13768045/diff/1/lily/align-interface.cc#oldcod...
lily/align-interface.cc:216: else if (!last_nonempty_element)
{
 for (int k = j; k--; ) translates[k] = dy * stacking_dir;

To match the ver2.16 code, bringing any empty lines to the same position as the
first full line.  (Better, though, if the code that estimated system height did
not depend on the positions of empty lines.)

https://codereview.appspot.com/13768045/diff/1/lily/align-interface.cc#oldcod...
lily/align-interface.cc:263: if (Page_layout_problem::is_spaceable (elems[j]))
  && ! skyline.is_empty() )
Doh.  We did not want to remember the previous Staff if it was empty.

Probably best to have the if-elsif-else construction above fill the whole for
loop, because this code after that construction is better done separately for
the if, elseif, and else situations.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b