|
In order to improve the consumability and management of Shindig in enterprise deployments, Shindig Java components should rely on Java Compatibility Kit (JCK) compliant libraries.
It's come to our attention that JUEL libraries are not JCK compliant. Fortunately, Jasper is. However, there is a minor discrepancy between the library APIs. The newly created 2.0 stream affords an opportunity to become JCK compliant and adjust the code accordingly.
The issue is org.apache.shindig.expressions.ShindigTypeConverter.java
implements JUEL interface de.odysseus.el.misc.TypeConverter which is not provided by Jasper. Therefore in the process of switching from JUEL to Jasper, most of the negation test cases fail in these two functions in the ExpressionTest.java class
public void booleanCoercionOfNumbers() and public void booleanCoercionOfString()
Here's the preliminary patch, any thought on where or how we can find a replacement equivalent to TypeConverter.java for use with jasper to get these testcases passing?
Total comments: 10
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+678 lines, -84 lines) |
Patch |
|
|
java/common/pom.xml
|
View
|
1
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/ELTypeConverter.java
|
View
|
|
1 chunk |
+44 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/ExpressionProvider.java
|
View
|
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/Expressions.java
|
View
|
1
|
4 chunks |
+104 lines, -40 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/ShindigTypeConverter.java
|
View
|
1
|
2 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/jasper/JasperConversionModule.java
|
View
|
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/jasper/JasperModule.java
|
View
|
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/jasper/JasperProvider.java
|
View
|
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/jasper/JasperTypeConverter.java
|
View
|
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/juel/JuelModule.java
|
View
|
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/juel/JuelProvider.java
|
View
|
|
1 chunk |
+73 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/main/java/org/apache/shindig/expressions/juel/JuelTypeConverter.java
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java
|
View
|
1
|
6 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
|
|
java/common/src/test/java/org/apache/shindig/expressions/FunctionsTest.java
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
|
java/common/src/test/java/org/apache/shindig/expressions/OpensocialFunctionsTest.java
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
|
java/common/src/test/java/org/apache/shindig/expressions/jasper/JasperExpressionsTest.java
|
View
|
|
1 chunk |
+65 lines, -0 lines |
0 comments
|
Download
|
|
|
java/common/src/test/java/org/apache/shindig/expressions/juel/JuelExpressionsTest.java
|
View
|
|
1 chunk |
+81 lines, -0 lines |
0 comments
|
Download
|
|
|
java/gadgets/pom.xml
|
View
|
1
|
1 chunk |
+2 lines, -7 lines |
0 comments
|
Download
|
|
|
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
|
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateELResolver.java
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
|
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/DefaultServiceFetcherTest.java
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
|
java/samples/pom.xml
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
|
java/server/pom.xml
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
|
java/social-api/pom.xml
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
|
pom.xml
|
View
|
1
|
1 chunk |
+16 lines, -5 lines |
0 comments
|
Download
|
Total messages: 10
|