Issue 1327043: Fix 1063: Nested property revert

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1327043: Fix 1063: Nested property revert (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Carl

Modified:
13 years, 8 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1063: Nested property revert

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add regression test. #

Patch Set 3 : Respond to Carl's comments #

Total comments: 3

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -9 lines)			Patch
	A	input/regression/nested-property-revert.ly	View		1 chunk	+18 lines, -0 lines	1 comment	Download
	M	lily/nested-property.cc	View	1 2	3 chunks	+34 lines, -9 lines	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Carl

I think that this patch works. I've tested it with the regression tests and I've ...

13 years, 11 months ago (2010-05-27 04:00:49 UTC) #1

Carl

Please review this patch created by xhero to fix bug 1063. I found one comment ...

13 years, 10 months ago (2010-07-02 15:51:50 UTC) #2

xhero.gm

Hi Carl, didn't you receive my updated patch? I have been on thesis-zone, so I ...

13 years, 10 months ago (2010-07-03 05:23:47 UTC) #3

Carl

I'm sorry, Rodolfo. I did receive your patch, but somehow overlooked it. Thanks, Carl

13 years, 10 months ago (2010-07-03 10:53:21 UTC) #4

Neil Puttock

13 years, 10 months ago (2010-07-04 21:40:09 UTC) #6

LGTM.

http://codereview.appspot.com/1327043/diff/8001/9001
File input/regression/nested-property-revert.ly (right):

http://codereview.appspot.com/1327043/diff/8001/9001#newcode1
input/regression/nested-property-revert.ly:1: \version "2.13.19"
2.13.27

http://codereview.appspot.com/1327043/diff/8001/9002
File lily/nested-property.cc (right):

http://codereview.appspot.com/1327043/diff/8001/9002#newcode64
lily/nested-property.cc:64: int copy_found = 0;
copy_found suggests a boolean; copy_count would reflect its usage better

http://codereview.appspot.com/1327043/diff/8001/9002#newcode113
lily/nested-property.cc:113: if (!drop) {
if (!drop)
  {

Expand All Messages | Collapse All Messages