Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(624)

Issue 132050: Adding makeself source to third_party

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by nmaxwell
Modified:
15 years, 8 months ago
CC:
o3d-review_googlegroups.com, tschmelcher
Base URL:
http://o3d.googlecode.com/svn/trunk/googleclient/third_party/
Visibility:
Public.

Description

Adding makeself source to third_party

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1913 lines, -0 lines) Patch
A makeself_2_1_5/COPYING View 1 chunk +341 lines, -0 lines 0 comments Download
A makeself_2_1_5/LICENSE View 1 chunk +341 lines, -0 lines 0 comments Download
A makeself_2_1_5/README View 1 chunk +307 lines, -0 lines 0 comments Download
A makeself_2_1_5/README.google View 1 chunk +18 lines, -0 lines 0 comments Download
A makeself_2_1_5/TODO View 1 chunk +6 lines, -0 lines 0 comments Download
A makeself_2_1_5/makeself.1 View 1 chunk +76 lines, -0 lines 0 comments Download
A makeself_2_1_5/makeself.lsm View 1 chunk +16 lines, -0 lines 0 comments Download
A makeself_2_1_5/makeself.sh View 1 chunk +407 lines, -0 lines 0 comments Download
A makeself_2_1_5/makeself-header.sh View 1 chunk +401 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nmaxwell
15 years, 8 months ago (2009-10-16 17:13:11 UTC) #1
nmaxwell
FYI, Im submitting this as a new/replacement issue for this CL (already approved by you): ...
15 years, 8 months ago (2009-10-16 17:27:54 UTC) #2
tschmelcher1
LGTM
15 years, 8 months ago (2009-10-16 17:35:48 UTC) #3
piman
LGTM
15 years, 8 months ago (2009-10-16 17:40:57 UTC) #4
nmaxwell
On 2009/10/16 17:40:57, piman wrote: > LGTM Antoine, Im getting authorization errors from both gclient ...
15 years, 8 months ago (2009-10-16 20:08:58 UTC) #5
vangelis
15 years, 8 months ago (2009-10-23 22:52:10 UTC) #6
I checked in makeself to third_party.  Now have one more CL to map it via
gclient:  

http://codereview.chromium.org/333016


On 2009/10/16 20:08:58, nmaxwell wrote:
> On 2009/10/16 17:40:57, piman wrote:
> > LGTM
> 
> Antoine, Im getting authorization errors from both gclient and svn commit
> (authorization failed (http://o3d.googlecode.com)). jam@google says he thinks
it
> might be due to the fact that Im not an owner of O3D. Can you either add me as
> an owner to O3D, or maybe submit this CL for me? Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b