Issue 124048: Add Makeself sources to o3d/third_party.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124048: Add Makeself sources to o3d/third_party. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by noah.maxwell

Modified:
16 years, 6 months ago

Reviewers:
Antoine Labour, tschmelcher

CC:
o3d-review_googlegroups.com

Base URL:
http://o3d.googlecode.com/svn/trunk/googleclient/third_party/

Visibility:
Public.

Description

Add Makeself sources to o3d/third_party.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1913 lines, -0 lines)			Patch
A	makeself_2_1_5/COPYING	View		1 chunk	+341 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/LICENSE	View		1 chunk	+341 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/README	View	1 2	1 chunk	+307 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/README.google	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/TODO	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/makeself.1	View	1 2	1 chunk	+76 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/makeself.lsm	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/makeself.sh	View	1 2	1 chunk	+407 lines, -0 lines	0 comments	Download
A	makeself_2_1_5/makeself-header.sh	View		1 chunk	+401 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Antoine Labour

LGTM, but please remove the 2 Google internal files, they aren't needed in the public ...

16 years, 7 months ago (2009-09-25 22:31:28 UTC) #2

noah.maxwell

16 years, 7 months ago (2009-09-28 22:48:30 UTC) #4

noah.maxwell

16 years, 6 months ago (2009-10-14 21:36:51 UTC) #6

FYI, I am still unable to submit this due to this bug:

http://code.google.com/p/gclient/issues/detail?id=13

Still no response on the bug, so I think Im going to create this as a new issue
using my new nmaxwell@chromium account to see if I can submit it that way.

Expand All Messages | Collapse All Messages