Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2471)

Issue 1261043: code review 1261043: Freetype-Go: Paint now takes an explicit done bool inst... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by nigeltao
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev, rog
Visibility:
Public.

Description

Freetype-Go: Paint now takes an explicit done bool instead of using a magic zero value to indicate end of painting. This means that Painter implementations can assume thant the Spans' Y values are monotonic.

Patch Set 1 #

Patch Set 2 : code review 1261043: Freetype-Go: Paint now takes an explicit done bool inst... #

Patch Set 3 : code review 1261043: Freetype-Go: Paint now takes an explicit done bool inst... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M freetype/raster/paint.go View 7 chunks +35 lines, -37 lines 0 comments Download
M freetype/raster/raster.go View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello rsc (cc: golang-dev@googlegroups.com, rog), I'd like you to review this change.
14 years, 4 months ago (2010-05-21 19:55:07 UTC) #1
rsc
LGTM Another way to do this would have been to define that Paint(nil) means "done". ...
14 years, 4 months ago (2010-05-21 21:46:59 UTC) #2
nigeltao
14 years, 4 months ago (2010-05-21 22:09:31 UTC) #3
*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=759756f8db37 ***

Freetype-Go: Paint now takes an explicit done bool instead of using a
magic zero value to indicate end of painting.

This means that Painter implementations can assume thant the Spans' Y
values are monotonic.

R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/1261043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b