code review 12603049: bufio: drop Writer and Reset buffer recycling, add Rese...

bufio: drop buffer recycling, add Reader.Reset and Writer.Reset

Fixes issue 6086

[bradfitz, 2013-08-09 23:40:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[peted, 2013-08-09 23:55:27]

On 2013/08/09 23:40:50, bradfitz wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

This looks like exactly the sort of thing to go in doc/go1.2.txt

[r, 2013-08-09 23:56:32]

The plan is not to clutter the CLs but to update the doc in a separate CL.

[peted, 2013-08-10 00:00:47]

On 2013/08/09 23:56:32, r wrote:
> The plan is not to clutter the CLs but to update the doc in a separate CL.

Ah, I see. Understood.

[rsc, 2013-08-10 02:35:28]

LGTM

Thanks.

https://codereview.appspot.com/12603049/diff/5001/src/pkg/bufio/bufio.go
File src/pkg/bufio/bufio.go (right):

https://codereview.appspot.com/12603049/diff/5001/src/pkg/bufio/bufio.go#newc...
src/pkg/bufio/bufio.go:249: // The bytes stop being valid at the next read or
Reset call.
this is fine but they're probably still valid after Reset.

[bradfitz, 2013-08-11 02:22:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=b302ea285b42 ***

bufio: drop buffer recycling, add Reader.Reset and Writer.Reset

Fixes issue 6086

R=golang-dev, pieter, r, rsc
CC=golang-dev
https://codereview.appspot.com/12603049