Issue 1235041: code review 1235041: cmath: add package description

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1235041: code review 1235041: cmath: add package description (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Charlie Dorian

Modified:
15 years, 4 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

cmath: add package description Also update range of Phase and Polar due to signed zero. [Phase(cmplx(-1, +0)) = pi and Phase(cmplx(-1, -0)) = -pi]

Patch Set 1 #

Patch Set 2 : code review 1235041: cmath: add package description #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	src/pkg/cmath/abs.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/cmath/phase.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/cmath/polar.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 4 months ago (2010-05-15 04:05:31 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=973b247f2bbe *** cmath: add package description Also update range of Phase and ...

15 years, 4 months ago (2010-05-15 17:07:02 UTC) #3

rsc

> +// The cmath package provides basic constants > +// and mathematical functions for complex ...

15 years, 4 months ago (2010-05-21 06:34:50 UTC) #4

Charlie Dorian

15 years, 4 months ago (2010-05-21 14:27:37 UTC) #5

So far, only cmath.Inf() and cmath.NaN(), which were added when I
started looking at special cases.

(Recently, however, I've been working on IEEE 754 special cases for
the math package.  I wanted to get them right because cmath functions
depend on math functions.)

If you feel the wording is confusing, I'll submit a CL.

On Fri, May 21, 2010 at 2:34 AM, Russ Cox <rsc@golang.org> wrote:
>> +// The cmath package provides basic constants
>> +// and mathematical functions for complex numbers.
>
> what constants?
>

Expand All Messages | Collapse All Messages