Issue 122020043: code review 122020043: compiler: Handle enclosing vars for function type in fu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 122020043: code review 122020043: compiler: Handle enclosing vars for function type in fu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by iant

Modified:
10 years, 4 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: Handle enclosing vars for function type in function lit. This fixes a dumb bug in which the enclosing vars were incorrectly cleared when a function literal contains a reference to a function type. The test for this will go into the master repository in the change at http://codereview.appspot.com/121200043 . This fixes http://gcc.gnu.org/PR61308 .

Patch Set 1 #

Patch Set 2 : diff -r 8263b1ea5ea9 https://gofrontend.googlecode.com/hg/ #

Patch Set 3 : diff -r d7e00d7c498b https://gofrontend.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	go/parse.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

10 years, 4 months ago (2014-08-05 03:10:04 UTC) #1

iant

10 years, 4 months ago (2014-08-05 03:10:10 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=c4aba782c0cb ***

compiler: Handle enclosing vars for function type in function lit.

This fixes a dumb bug in which the enclosing vars were
incorrectly cleared when a function literal contains a
reference to a function type.  The test for this will go into
the master repository in the change at
http://codereview.appspot.com/121200043 .

This fixes http://gcc.gnu.org/PR61308 .

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/122020043

Expand All Messages | Collapse All Messages