code review 121200043: test: add test for function type in function literal

test: add test for function type in function literal

The gccgo compiler used to fail this test.  This was the root
cause of http://gcc.gnu.org/PR61308 .  The fix for the gccgo
compiler is http://codereview.appspot.com/122020043 .

[iant, 2014-08-05 02:38:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-08-05 02:43:10]

On 2014/08/05 02:38:46, iant wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

LGTM.

My old copy of gccgo-4.9 gets this completely wrong.

lucky(~/src) % go run -compiler=gccgo xxx.go
# command-line-arguments
./xxx.go:13:7: error: too few expressions for struct
  f := func() {
       ^
lucky(~/src) % gccgo -v
Using built-in specs.
COLLECT_GCC=gccgo
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.9/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu
4.9-20140406-0ubuntu1' --with-bugurl=file:///usr/share/doc/gccgo-4.9/README.Bugs
--enable-languages=c,c++,go --prefix=/usr --program-suffix=-4.9 --enable-shared
--enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.9
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libmudflap
--disable-libquadmath --enable-plugin --with-system-zlib --enable-multiarch
--disable-werror --with-arch-32=i686 --with-abi=m64
--with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic
--enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu
--target=x86_64-linux-gnu
Thread model: posix
gcc version 4.9.0 20140405 (experimental) [trunk revision 209157] (Ubuntu
4.9-20140406-0ubuntu1)

[bradfitz, 2014-08-05 02:43:31]

LGTM but s/sport/spot/ in CL description



On Mon, Aug 4, 2014 at 7:38 PM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: add test for function type in function literal
>
> The gccgo compiler used to fail this test.  This was the root
> cause of http://gcc.gnu.org/PR61308 .  The fix for the gccgo
> compiler is http://codereview.appsport.com/122020043 .
>
> Please review this at https://codereview.appspot.com/121200043/
>
> Affected files (+22, -0 lines):
>   A test/fixedbugs/bug489.go
>
>
> Index: test/fixedbugs/bug489.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug489.go
> @@ -0,0 +1,22 @@
> +// compile
> +
> +// Copyright 2014 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +// The gccgo compiler had a bug: mentioning a function type in an
> +// expression in a function literal messed up the list of variables
> +// referenced in enclosing functions.
> +
> +package main
> +
> +func main() {
> +       v1, v2 := 0, 0
> +       f := func() {
> +               a := v1
> +               g := (func())(nil)
> +               b := v2
> +               _, _, _ = a, g, b
> +       }
> +       _, _, _ = v1, v2, f
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-08-05 02:50:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=e6fade946dcb ***

test: add test for function type in function literal

The gccgo compiler used to fail this test.  This was the root
cause of http://gcc.gnu.org/PR61308 .  The fix for the gccgo
compiler is http://codereview.appspot.com/122020043 .

LGTM=dave, bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/121200043

[gobot, 2014-08-05 03:00:14]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/042f14b3f49b567d4af869726dd7ec3feb5d5d3f

[iant, 2014-08-05 03:20:45]

On Mon, Aug 4, 2014 at 8:00 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/042f14b3f49b567d4af869726dd7ec3feb5d5d3f
>
> https://codereview.appspot.com/121200043/

Not really.

pprof_test.go:136: crc32.ChecksumIEEE: 0
pprof_test.go:136: crc32.Update: 18
pprof_test.go:150: crc32.ChecksumIEEE has 0 samples out of 18, want at
least 1, ideally 9
FAIL
FAIL runtime/pprof 37.506s