Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 1218042: code review 1218042: go/printer (gofmt): don't lose mandatory semicolons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by gri
Modified:
15 years, 5 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

go/printer (gofmt): don't lose mandatory semicolons Fixes issue 779.

Patch Set 1 #

Patch Set 2 : code review 1218042: go/printer (gofmt): don't lose mandatory semicolons #

Patch Set 3 : code review 1218042: go/printer (gofmt): don't lose mandatory semicolons #

Patch Set 4 : code review 1218042: go/printer (gofmt): don't lose mandatory semicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M src/pkg/go/printer/nodes.go View 1 2 13 chunks +20 lines, -16 lines 0 comments Download
M src/pkg/go/printer/printer.go View 3 chunks +3 lines, -1 line 0 comments Download
M src/pkg/go/printer/testdata/statements.golden View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/statements.input View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 5 months ago (2010-05-14 22:15:27 UTC) #1
r
LGTM
15 years, 5 months ago (2010-05-14 22:22:18 UTC) #2
gri
15 years, 5 months ago (2010-05-14 22:38:32 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bcc5f50c686f ***

go/printer (gofmt): don't lose mandatory semicolons

Fixes issue 779.

R=r
CC=golang-dev
http://codereview.appspot.com/1218042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b