Issue 1196045: code review 1196045: Freetype-Go: support compound glyphs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1196045: code review 1196045: Freetype-Go: support compound glyphs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by nigeltao

Modified:
14 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 1196045: Freetype-Go: support compound glyphs. #

Patch Set 3 : code review 1196045: Freetype-Go: support compound glyphs. #

Total comments: 3

Patch Set 4 : code review 1196045: Freetype-Go: support compound glyphs. #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -20 lines)			Patch
	M	freetype/truetype/truetype.go	View	1 2 3	5 chunks	+102 lines, -20 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-05-19 04:55:11 UTC) #1

nigeltao_gnome

Eh, the gamma change isn't related to the compound glyph change, so I've spun the ...

14 years, 6 months ago (2010-05-19 05:07:38 UTC) #2

LGTM http://codereview.appspot.com/1196045/diff/7001/8001 File freetype/truetype/truetype.go (right): http://codereview.appspot.com/1196045/diff/7001/8001#newcode437 freetype/truetype/truetype.go:437: flagOnCurve = 1 << iota these names are ...

14 years, 6 months ago (2010-05-20 02:41:09 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/freetype-go/source/detail?r=4aa2785a76e2 *** Freetype-Go: support compound glyphs. R=r CC=golang-dev http://codereview.appspot.com/1196045

14 years, 6 months ago (2010-05-20 12:31:56 UTC) #4

nigeltao_gnome

14 years, 6 months ago (2010-05-20 12:32:13 UTC) #5

On 19 May 2010 19:41,  <r@golang.org> wrote:
> http://codereview.appspot.com/1196045/diff/7001/8001
> File freetype/truetype/truetype.go (right):
>
> http://codereview.appspot.com/1196045/diff/7001/8001#newcode536
> freetype/truetype/truetype.go:536: dx, dy = int16(d.u16()),
> int16(d.u16())
> there's nothing wrong with this but you're getting nothing from doing
> double assignment and it makes people think about evaluation order. why
> not just make them two statements?

Done.


> http://codereview.appspot.com/1196045/diff/7001/8001#newcode588
> freetype/truetype/truetype.go:588: if ne == 1<<16-1 {
> what is the derivation of this constant?

I've rejigged it (int16 instead of uint16) so that it's a little more
clear that -1 means compound glyph, as says
http://developer.apple.com/fonts/TTRefMan/RM06/Chap6glyf.html

Expand All Messages | Collapse All Messages