[PATCH] Make libc++ compile on linux

I'm working on Ubuntu Hardy. Your mileage may vary on other platforms. :)

Everything compiles with this patch.  The link currently fails with:

+ g++ algorithm.o bind.o chrono.o condition_variable.o exception.o hash.o ios.o iostream.o locale.o memory.o mutex.o new.o random.o stdexcept.o strstream.o system_error.o thread.o typeinfo.o utility.o valarray.o -fPIC -o libc++.so.1.0 -shared -nodefaultlibs -Wl,-soname,libc++.so.1 -lstdc++ -lc
exception.o:(.data.rel.ro._ZTISt13bad_exception[typeinfo for std::bad_exception]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
ios.o:(.data.rel.ro._ZTINSt3__119__iostream_categoryE[typeinfo for std::__1::__iostream_category]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
ios.o:(.data.rel.ro._ZTINSt3__19basic_iosIwNS_11char_traitsIwEEEE[typeinfo for std::__1::basic_ios<wchar_t, std::__1::char_traits<wchar_t> >]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
ios.o:(.data.rel.ro._ZTINSt3__19basic_iosIcNS_11char_traitsIcEEEE[typeinfo for std::__1::basic_ios<char, std::__1::char_traits<char> >]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
ios.o:(.data.rel.ro._ZTINSt3__18ios_base7failureE[typeinfo for std::__1::ios_base::failure]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
iostream.o:(.data.rel.ro._ZTINSt3__110__stdinbufIcEE[typeinfo for std::__1::__stdinbuf<char>]+0x0): more undefined references to `vtable for __cxxabiv1::__si_class_type_info' follow
/usr/bin/ld: libc++.so.1.0: hidden symbol `vtable for __cxxabiv1::__si_class_type_info' isn't defined
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status


None of the tests have been tested.

[Jeffrey Yasskin, 2010-05-19 21:29:19]

Let me know what you think.

[clattner_apple.com, 2010-05-20 05:23:59]

On May 19, 2010, at 2:29 PM, jyasskin@gmail.com wrote:

> Reviewers: cfe-dev_cs.uiuc.edu,
> 
> Message:
> Let me know what you think.

For the atomics, would it be possible to use the builtins for them instead of
the OSAtomic* and inline asm.

-Chris

> 
> Description:
> I'm working on Ubuntu Hardy. Your mileage may vary on other platforms.
> :)
> 
> Everything compiles with this patch.  The link currently fails with:
> 
> + g++ algorithm.o bind.o chrono.o condition_variable.o exception.o
> hash.o ios.o iostream.o locale.o memory.o mutex.o new.o random.o
> stdexcept.o strstream.o system_error.o thread.o typeinfo.o utility.o
> valarray.o -fPIC -o libc++.so.1.0 -shared -nodefaultlibs
> -Wl,-soname,libc++.so.1 -lstdc++ -lc
> exception.o:(.data.rel.ro._ZTISt13bad_exception[typeinfo for
> std::bad_exception]+0x0): undefined reference to `vtable for
> __cxxabiv1::__si_class_type_info'
> ios.o:(.data.rel.ro._ZTINSt3__119__iostream_categoryE[typeinfo for
> std::__1::__iostream_category]+0x0): undefined reference to `vtable for
> __cxxabiv1::__si_class_type_info'
> ios.o:(.data.rel.ro._ZTINSt3__19basic_iosIwNS_11char_traitsIwEEEE[typeinfo
> for std::__1::basic_ios<wchar_t, std::__1::char_traits<wchar_t> >]+0x0):
> undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
> ios.o:(.data.rel.ro._ZTINSt3__19basic_iosIcNS_11char_traitsIcEEEE[typeinfo
> for std::__1::basic_ios<char, std::__1::char_traits<char> >]+0x0):
> undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
> ios.o:(.data.rel.ro._ZTINSt3__18ios_base7failureE[typeinfo for
> std::__1::ios_base::failure]+0x0): undefined reference to `vtable for
> __cxxabiv1::__si_class_type_info'
> iostream.o:(.data.rel.ro._ZTINSt3__110__stdinbufIcEE[typeinfo for
> std::__1::__stdinbuf<char>]+0x0): more undefined references to `vtable
> for __cxxabiv1::__si_class_type_info' follow
> /usr/bin/ld: libc++.so.1.0: hidden symbol `vtable for
> __cxxabiv1::__si_class_type_info' isn't defined
> /usr/bin/ld: final link failed: Nonrepresentable section on output
> collect2: ld returned 1 exit status
> 
> 
> None of the tests have been tested.
> 
> Please review this at http://codereview.appspot.com/1164043/show
> 
> Affected files:
>   A     include/__atomic_hack
>   M     include/__config
>   M     include/__locale
>   M     include/algorithm
>   M     include/cstddef
>   M     include/iosfwd
>   M     include/locale
>   M     include/string
>   M     include/thread
>   M     lib/buildit
>   M     src/chrono.cpp
>   M     src/exception.cpp
>   M     src/ios.cpp
>   M     src/locale.cpp
>   M     src/memory.cpp
>   M     src/mutex.cpp
>   M     src/new.cpp
>   M     src/stdexcept.cpp
>   M     src/system_error.cpp
>   M     src/thread.cpp
> 
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

[Jeffrey Yasskin (google), 2010-05-23 07:00:10]

On Wed, May 19, 2010 at 10:23 PM, Chris Lattner <clattner@apple.com> wrote:
>
> On May 19, 2010, at 2:29 PM, jyasskin@gmail.com wrote:
>
>> Reviewers: cfe-dev_cs.uiuc.edu,
>>
>> Message:
>> Let me know what you think.
>
> For the atomics, would it be possible to use the builtins for them instead of
the OSAtomic* and inline asm.

Done.

--
http://codereview.appspot.com/1164043

[hhinnant_apple.com, 2010-05-24 17:52:54]

On May 23, 2010, at 2:59 AM, Jeffrey Yasskin wrote:

> On Wed, May 19, 2010 at 10:23 PM, Chris Lattner <clattner@apple.com> wrote:
>> 
>> On May 19, 2010, at 2:29 PM, jyasskin@gmail.com wrote:
>> 
>>> Reviewers: cfe-dev_cs.uiuc.edu,
>>> 
>>> Message:
>>> Let me know what you think.
>> 
>> For the atomics, would it be possible to use the builtins for them instead of
the OSAtomic* and inline asm.
> 
> Done.

Thanks much Jeffrey.  This is checked in now.  I did a little bit of
modification with the <locale> __nolocale_* functions.

-Howard