Issue 1158043: code review 1158043: proto: update the library to be in sync with Google's i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1158043: code review 1158043: proto: update the library to be in sync with Google's i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by r

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

proto: update the library to be in sync with Google's internal code.

Patch Set 1 #

Patch Set 2 : code review 1158043: proto: update the library to be in sync with Google's i... #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -26 lines)			Patch
M	proto/all_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	proto/text_parser_test.go	View	7 chunks	+21 lines, -21 lines	0 comments	Download
M	proto/text_test.go	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 3 months ago (2010-05-11 04:41:26 UTC) #1

This is a purely mechanical edit containing only spaces due to gofmt and one newline ...

15 years, 3 months ago (2010-05-11 04:43:01 UTC) #2

15 years, 3 months ago (2010-05-11 23:04:59 UTC) #4

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=12886516f60d ***

proto: update the library to be in sync with Google's internal code.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1158043

Committer: Rob Pike <r@golang.org>