Issue 115480043: Issue 4039: Improvements to magnifyMusic and magnifyStaff.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115480043: Issue 4039: Improvements to magnifyMusic and magnifyStaff.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Mark Polesky

Modified:
9 years, 9 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Scale tablature half-note double-stems. Scale baseline-skip and word-space props.* Add regtests. *this requires adding text-interface to InstrumentName, which is the subject of Issue 4038. Issue 4039 on tracker: http://code.google.com/p/lilypond/issues/detail?id=4039

Patch Set 1 #

Patch Set 2 : Remove redundant scaling. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -39 lines)			Patch
A	input/regression/magnifyMusic-tablature-double-stems.ly	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	input/regression/magnifyMusic-text-interface.ly	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	input/regression/magnifyStaff-tablature-double-stems.ly	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	input/regression/magnifyStaff-text-interface.ly	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	ly/music-functions-init.ly	View	4 chunks	+35 lines, -19 lines	0 comments	Download
M	scm/define-grobs.scm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	scm/music-functions.scm	View	4 chunks	+42 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Polesky

Here are some improvements to magnifyMusic and magnifyStaff. Nothing major, but please have a look. ...

9 years, 9 months ago (2014-07-30 23:52:59 UTC) #1

LGTM (but i have only skimmed the code).

Expand All Messages | Collapse All Messages