Issue 1145044: code review 1145044: implement os.FileInfo.*time_ns for windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1145044: code review 1145044: implement os.FileInfo.*time_ns for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by brainman

Modified:
14 years, 9 months ago

Reviewers:
peterGo

CC:
golang-dev, adg

Visibility:
Public.

Description

implement os.FileInfo.*time_ns for windows

Patch Set 2 : code review 1145044: implement os.FileInfo.*time_ns for windows #

Patch Set 3 : code review 1145044: implement os.FileInfo.*time_ns for windows #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	src/pkg/os/stat_windows.go	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/ztypes_windows_386.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 10 months ago (2010-05-12 23:59:48 UTC) #1

brainman

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 9 months ago (2010-05-25 00:30:57 UTC) #2

adg

LGTM Alex, is this okay for me to submit? On 2010/05/25 00:30:57, brainman wrote: > ...

14 years, 9 months ago (2010-05-31 08:20:44 UTC) #3

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=d1ae873fca90 *** implement os.FileInfo.*time_ns for windows R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/1145044 Committer: Andrew ...

14 years, 9 months ago (2010-05-31 11:43:48 UTC) #4

peterGo

Yesterday, I read the messages posted in the Windows Port Status thread, so I looked ...

14 years, 9 months ago (2010-05-31 13:48:34 UTC) #5

adg

14 years, 9 months ago (2010-05-31 14:14:08 UTC) #6

On 31 May 2010 15:48,  <go.peter.90@gmail.com> wrote:
> Yesterday, I read the messages posted in the Windows Port Status thread,
> so I looked at this patch. I just logged on to post a review of this
> change, to tell you about some bugs and other problems. I see you've
> already committed it.

It happens. Make the changes and submit a CL.

> On 2010/05/31 11:43:48, adg wrote:
>>
>> *** Submitted as
>
> http://code.google.com/p/go/source/detail?r=d1ae873fca90 ***
>
>> implement os.FileInfo.*time_ns for windows
>
>> R=golang-dev, adg
>> CC=golang-dev
>> http://codereview.appspot.com/1145044
>
>> Committer: Andrew Gerrand <mailto:adg@golang.org>
>
>
>
> http://codereview.appspot.com/1145044/show
>

Expand All Messages | Collapse All Messages