LIB Fix b/15187210: Better log message when dashboard login fails

This change will include the GSA admin URL in the log message when
failing to connect the the GSA admin port for authentication.
Note that this was somewhat difficult since the error originates
from deep within GData apis.  It would be better if the URI
would have been included in construction of the original exception:
com.google.gdata.util.AuthenticationException: Error connecting with login URI

This only fixes messages logged in the log file, and not the error
message that is displayed on the dashboard login page.

[pjo, 2014-06-27 01:28:22]

Thank you.

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java
(right):

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: if
(e.getCause() instanceof ConnectException) {
does this execption instance have interesting info?

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:207: } else
if (e.getCause() instanceof UnknownHostException) {
does this execption instance have interesting info?

[Brett, 2014-06-27 22:18:39]

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java
(right):

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: if
(e.getCause() instanceof ConnectException) {
On 2014/06/27 01:28:22, pjo wrote:
> does this execption instance have interesting info?

The GSA is down or refusing connections.  Are you suggesting that I provide a
better log message?

https://codereview.appspot.com/110200046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:207: } else
if (e.getCause() instanceof UnknownHostException) {
On 2014/06/27 01:28:22, pjo wrote:
> does this execption instance have interesting info?

The adapter cannot resolve the hostname.  So the feed.admin.hostname  property
may be incorrectly set, or the name server is down.

[pjo, 2014-06-27 22:21:09]

Sorry for not being clear.

It seems in the authn() method we get
exceptions whose messages we ignore and
return an INTERMEDIATE result.

Then we interpret the intermediate result
and make a message.  I was wondering if
logging the message we ignore would mean 
we don't have to make up our own detailed
message.

Thank you,
PJ

[brett.michael.johnson_gmail.com, 2014-06-27 22:38:26]

We are are logging the exceptions (at FINE???) in 
Then we log it again after seeing INTERMEDIDATE.
I think the log messages could be much clearer.
I am not happy with this CL, and will redo it.
—
Brett M. Johnson

On Jun 27, 2014, at 3:21 PM, pjo@google.com wrote:

> Sorry for not being clear.
> 
> It seems in the authn() method we get
> exceptions whose messages we ignore and
> return an INTERMEDIATE result.
> 
> Then we interpret the intermediate result
> and make a message.  I was wondering if
> logging the message we ignore would mean
> we don't have to make up our own detailed
> message.
> 
> Thank you,
> PJ
> 
> https://codereview.appspot.com/110200046/

[Brett, 2014-06-28 00:48:15]

Better log messages in general for failed GSA communications

[pjo, 2014-06-28 00:57:00]

Thank you.  LGTM.

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java
(right):

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: +
"Console at " + adminUrl() + " . If the GSA is not offline "
s/not offline/online/
?

[Brett, 2014-06-28 01:32:17]

Committed 27 June 2014 to the Adaptor Library:

To https://code.google.com/p/plexi/
   a15692a..6451260  master -> master

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
File src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java
(right):

https://codereview.appspot.com/110200046/diff/20001/src/com/google/enterprise...
src/com/google/enterprise/adaptor/AdministratorSecurityHandler.java:205: +
"Console at " + adminUrl() + " . If the GSA is not offline "
On 2014/06/28 00:57:00, pjo wrote:
> s/not offline/online/
> ?

Done.