Issue 1083041: code review 1083041: runtime: avoid allocation for fixed strings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1083041: code review 1083041: runtime: avoid allocation for fixed strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: avoid allocation for fixed strings

Patch Set 1 #

Patch Set 2 : code review 1083041: runtime: avoid allocation for fixed strings #

Patch Set 3 : code review 1083041: runtime: avoid allocation for fixed strings #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -14 lines)			Patch
M	src/pkg/runtime/darwin/386/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/darwin/amd64/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/freebsd/386/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/iface.c	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/linux/386/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/linux/amd64/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/linux/arm/signal.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/string.goc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/symtab.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-05-20 01:13:25 UTC) #1

rsc

15 years ago (2010-05-20 04:33:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f7e1cbc5ce28 ***

runtime: avoid allocation for fixed strings

R=r
CC=golang-dev
http://codereview.appspot.com/1083041

Expand All Messages | Collapse All Messages