Issue 10819043: PATCH: Issue 519: Warn about cross-platform font inconsistencies. (Closed)
|
Created:
10 years, 10 months ago by Mark Polesky Modified:
10 years, 8 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionIssue 519: Warn about cross-platform font inconsistencies.
Patch Set 1 #Patch Set 2 : Removed an extra space that was in a bad place. #MessagesTotal messages: 6
I don't know if this qualifies for a "Fixed" label on Issue 519, but let me know what you think. http://code.google.com/p/lilypond/issues/detail?id=519 Thanks. - Mark
Sign in to reply to this message.
Mark, On 1 July 2013 03:39, <markpolesky@gmail.com> wrote: > Reviewers: , > > Message: > I don't know if this qualifies for a "Fixed" label on Issue 519, but let > me know what you think. > > http://code.google.com/p/**lilypond/issues/detail?id=519<http://code.google.c... > > Thanks. > - Mark > > Description: > Issue 519: Warn about cross-platform font inconsistencies. > > Please review this at https://codereview.appspot.**com/10819043/<https://codereview.appspot.com/108... > > Affected files: > M Documentation/notation/text.**itely > > > Index: Documentation/notation/text.**itely > diff --git a/Documentation/notation/text.**itely > b/Documentation/notation/text.**itely > index 89c82c7d217f4b4cc936ed19681c25**c0b6c921f5..** > 0799f61259ed5ba30cabf5e2fcfd54**f54b3021f8 100644 > --- a/Documentation/notation/text.**itely > +++ b/Documentation/notation/text.**itely > @@ -1402,6 +1402,14 @@ Three families of text fonts are made available: > the @emph{roman} > @emph{sans} font and the monospaced @emph{typewriter} font -- these > last two families are determined by the Pango installation. > > +@warning {There are no default fonts associated with the @emph{sans} > +and @emph{typewriter} font-families. An input file that specifies > +either of these can lead to different output on different computers. > +To ensure consistent output among multiple platforms, fonts must be > +specified by name, and those fonts must be available on any system > +that processes the file. See @ref{Single entry fonts} and > +@ref{Entire document fonts}.} > + > Each family may include different shapes and series. The following > example demonstrates the ability to select alternate families, shapes, > series and sizes. The value supplied to @code{font-size} is the > > > > ______________________________**_________________ > lilypond-devel mailing list > lilypond-devel@gnu.org > https://lists.gnu.org/mailman/**listinfo/lilypond-devel<https://lists.gnu.org... > And this is why. There has been no label change on this to know that it needs to be tested before it is then reviewed, Fortunately you at least put the tracker number in the summary. So I will go and change that for you so it gets tested. James
Sign in to reply to this message.
On 2013/07/01 07:27:41, J_lowe wrote: > And this is why. > > There has been no label change on this to know that it needs to be tested > before it is then reviewed, > > Fortunately you at least put the tracker number in the summary. > > So I will go and change that for you so it gets tested. Ah. I thought I was missing something! I just wasn't sure what. So, on the Issue page, I need to... 1) post a link to the patch on Rietveld 2) change Status to "Started" 3) change Owner to me 4) add Label "Patch-new" Anything else? Do I Cc it -devel or something? Or does the bug squad get automatically notified every time an issue gets updated? Also, is this procedure in the CG somewhere? I think I got it now, I tried this out here, should be good, let me know: http://code.google.com/p/lilypond/issues/detail?id=1337 Sorry to have made more work for you, I really just didn't know the procedure. Thanks.
Sign in to reply to this message.
Mark, On 1 July 2013 08:59, <markpolesky@gmail.com> wrote: > On 2013/07/01 07:27:41, J_lowe wrote: > >> And this is why. >> > > There has been no label change on this to know that it needs to be >> > tested > >> before it is then reviewed, >> > > Fortunately you at least put the tracker number in the summary. >> > > So I will go and change that for you so it gets tested. >> > > Ah. I thought I was missing something! I just wasn't sure what. > So, on the Issue page, I need to... > 1) post a link to the patch on Rietveld > 2) change Status to "Started" > 3) change Owner to me > 4) add Label "Patch-new" > > Anything else? Do I Cc it -devel or something? Or does the bug squad > get automatically notified every time an issue gets updated? Also, is > this procedure in the CG somewhere? > > I think I got it now, I tried this out here, should be good, let me > know: > http://code.google.com/p/**lilypond/issues/detail?id=1337<http://code.google.... > > Sorry to have made more work for you, I really just didn't know the > procedure. > > Thanks. > > https://codereview.appspot.**com/10819043/<https://codereview.appspot.com/108... > This manual process is ok. What I cannot seem to recall is how to get the automated scripts to use https:// so that's why i go back and change it to http:// the 'git-cl' scripts that we now provide (see http://lilypond.org/doc/v2.17/Documentation/contributor-big-page.html#uploadi... the 'git-cl install' section below) will automate most of this process for you, so once you configure it you run the git-cl scripts, it updates the tracker, posts to reitveld and so sends the email when you run them. However, as long as the google tracker label is 'patch-new' the test scripts it will find *any* patch-new and apply it to current master and run the various tests (make, make check - and I also run a full make doc as I have a server that can churn through that quite quickly). It isn't mandatory to change the owner or status, but it is good form for the developers. The email from Reitveld should also be sent as this will go to dev. if you do star a tracker issue (or create one) then you will also get the email from that, but of course the dev group won't. There is a new mail list (since you last contributed I think) that we have here: Now of course anyone can run the 'patchy test' scripts if they so wish (David K does this when I am not around) but generally it is only he and I and Phil occasionally. Some patches need human interaction to check the reg test diffs and post them to the tracker if they are different or show regressions etc. Otherwise, many devs do the manual method like you
Sign in to reply to this message.
Hello, sorry my typing skills were such I hit return by mistake and sent an incomplete email On 1 July 2013 08:59, <markpolesky@gmail.com> wrote: > On 2013/07/01 07:27:41, J_lowe wrote: > >> And this is why. >> > > There has been no label change on this to know that it needs to be >> > tested > >> before it is then reviewed, >> > > Fortunately you at least put the tracker number in the summary. >> > > So I will go and change that for you so it gets tested. >> > > Ah. I thought I was missing something! I just wasn't sure what. > So, on the Issue page, I need to... > 1) post a link to the patch on Rietveld > 2) change Status to "Started" > 3) change Owner to me > 4) add Label "Patch-new" > > Anything else? Do I Cc it -devel or something? Or does the bug squad > get automatically notified every time an issue gets updated? Also, is > this procedure in the CG somewhere? > > I think I got it now, I tried this out here, should be good, let me > know: > http://code.google.com/p/**lilypond/issues/detail?id=1337<http://code.google.... > > Sorry to have made more work for you, I really just didn't know the > procedure. > > Thanks. > > https://codereview.appspot.**com/10819043/<https://codereview.appspot.com/108... > This manual process is ok. What I cannot seem to recall is how to get the automated scripts to use https:// so that's why i go back and change it to http:// the 'git-cl' scripts that we now provide (see http://lilypond.org/doc/v2.17/Documentation/contributor-big-page.html#uploadi... the 'git-cl install' section below) will automate most of this process for you, so once you configure it you run the git-cl scripts, it updates the tracker, posts to reitveld and so sends the email when you run them. However, as long as the google tracker label is 'patch-new' the test scripts it will find *any* patch-new and apply it to current master and run the various tests (make, make check - and I also run a full make doc as I have a server that can churn through that quite quickly). It isn't mandatory to change the owner or status, but it is good form for the developers. The email from Reitveld should also be sent as this will go to dev. if you do star a tracker issue (or create one) then you will also get the email from that, but of course the dev group won't. There is a new mail list (since you last contributed I think) that we have here: http://lists.gnu.org/archive/html/lilypond-auto/ This lists all updates from all trackers from anyone. But I am not sure how many people check this. Hence the need to send the reitveld message too, to get the reviews. Now if all that fails! Then the PATCHES: Countdown email alerts everyone in a nice to read format, some devs only bother with current patches that are about to be pushed and only those that have at least passed the tests. Now of course anyone can run the 'patchy test' scripts if they so wish (David K does this when I am not around) but generally it is only he and I and Phil occasionally. Some patches need human interaction to check the reg test diffs and post them to the tracker if they are different or show regressions etc. Otherwise, many devs do the manual method like you James PS Don't forget that we no longer push directly to master, but to staging. There are further scripts that are run that merge the two trees every hour or so, so if something breaks in staging it won't be merged and so break master as well. It's a kind of safety net.
Sign in to reply to this message.
|
