Issue 1063042: code review 1063042: fix nacl build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1063042: code review 1063042: fix nacl build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

fix nacl build

Patch Set 1 #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/8l/pass.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-05-03 07:04:46 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=faeb8838c10c *** fix nacl build TBR=r CC=golang-dev http://codereview.appspot.com/1063042

15 years, 2 months ago (2010-05-03 07:04:51 UTC) #2

15 years, 2 months ago (2010-05-03 15:36:25 UTC) #3

LGTM

On May 3, 2010, at 12:04 AM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> fix nacl build
> 
> Please review this at http://codereview.appspot.com/1063042/show
> 
> Affected files:
>  M src/cmd/8l/pass.c
> 
> 
> Index: src/cmd/8l/pass.c
> ===================================================================
> --- a/src/cmd/8l/pass.c
> +++ b/src/cmd/8l/pass.c
> @@ -164,7 +164,7 @@
> 	xdefine("edata", SBSS, datsize);
> 	xdefine("end", SBSS, dynptrsize + bsssize + datsize);
> 
> -	if(debug['s'])
> +	if(debug['s'] || HEADTYPE == 8)
> 		xdefine("symdat", SFIXED, 0);
> 	else
> 		xdefine("symdat", SFIXED, SYMDATVA);
> 
>

Expand All Messages | Collapse All Messages