Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5195)

Issue 10329043: outside-staff-padding: add just one pad; issue 2910 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Keith
Modified:
10 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

When two grobs using 'outside-staff-padding are placed against each other, use the larger of the two grobs' values of 'outside-staff-padding. Same for 'outside-staff-horizon-padding. Commit 28f32949 had started to place two pads between outside-staff items, but just one pad to the staff. The C-code-default for 'outside-staff-padding was also inconsistent between locations in the code. Since then, some padding values were defined for individual grobs. These values are no longer needed.

Patch Set 1 #

Patch Set 2 : remove settings that are near the default #

Patch Set 3 : explicit scope #

Patch Set 4 : use larger of outside-staff-paddings between grobs #

Patch Set 5 : remove documentation changes #

Patch Set 6 : documentation only #

Total comments: 1

Patch Set 7 : no need to say 'previously-positioned' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M Documentation/notation/spacing.itely View 1 2 3 4 5 6 1 chunk +7 lines, -6 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Janek Warchol
Could you add some information in the commit message explaining why had you changed the ...
10 years, 8 months ago (2013-09-01 16:54:00 UTC) #1
Keith
On 2013/09/01 16:54:00, Janek Warchol wrote: > Could you add some information in the commit ...
10 years, 8 months ago (2013-09-02 20:10:36 UTC) #2
Trevor Daniels
https://codereview.appspot.com/10329043/diff/20001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/10329043/diff/20001/Documentation/notation/spacing.itely#newcode2726 Documentation/notation/spacing.itely:2726: previously-positioned grobs can be controlled with I don't think ...
10 years, 8 months ago (2013-09-04 22:27:18 UTC) #3
Keith
10 years, 8 months ago (2013-09-04 23:49:02 UTC) #4
On 2013/09/04 22:27:18, Trevor Daniels wrote:

> I don't think we should talk about "previously-positioned"
> 
True, that.
"The vertical padding around outside-staff objects can be controlled with
@code{outside-staff-padding}."
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b