code review 1032043: vector: use correct capacity in call to make

vector: use correct capacity in call to make

[rsc, 2010-05-01 00:28:00]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-05-01 00:40:47]

LGTM

http://codereview.appspot.com/1032043/diff/2001/3001
File src/pkg/container/vector/intvector.go (right):

http://codereview.appspot.com/1032043/diff/2001/3001#newcode192
src/pkg/container/vector/intvector.go:192: func (p *IntVector) AppendVector(x
*IntVector) { p.InsertVector(len(*p), x) }
undo this?

http://codereview.appspot.com/1032043/diff/2001/3002
File src/pkg/container/vector/stringvector.go (right):

http://codereview.appspot.com/1032043/diff/2001/3002#newcode192
src/pkg/container/vector/stringvector.go:192: func (p *StringVector)
AppendVector(x *StringVector) { p.InsertVector(len(*p), x) }
undo this?

[jan_mercl, 2010-05-01 05:48:09]

On 2010/05/01 00:28:00, rsc wrote:
> I'd like you to review this change.

a) At a glance it seems to me, that realloc() can see capacity < length only
being called from Slice(), so the adjusting could be put there (a tiny bit of
performance although realloc() is a more correct place for the check).

b) intvector and stringvector are generated from vector. Should they be included
in the CL?

[rsc, 2010-05-01 19:56:03]

> http://codereview.appspot.com/1032043/diff/2001/3001#newcode192
> src/pkg/container/vector/intvector.go:192: func (p *IntVector)
> AppendVector(x *IntVector) { p.InsertVector(len(*p), x) }
> undo this?

I didn't do it; "make generate" did, because gofmt has
slightly different rules since the last time.

Russ

[rsc, 2010-05-01 20:00:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=9bfc0abd402b ***

vector: use correct capacity in call to make

R=gri, r, bflm
CC=golang-dev
http://codereview.appspot.com/1032043