Issue 3951: Fix broken LSR links in docs.

Issue 3951: Fix broken LSR links in docs.

Not sure why, but the URL for the LSR seems to have changed from:
  lsr.dsi.unimi.it
to
  lsr.di.unimi.it

for i in $(git grep -l 'lsr.*dsi.*unimi.*it' |
           sed '/Documentation\/snippets/d'); do
  sed -i 's/lsr\(.*\)dsi\(.*\)unimi\(.*\)it/lsr\1di\2unimi\3it/' $i;
done

This accommodates both of the following cases:
  lsr.dsi.unimi.it       -> lsr.di.unimi.it
  lsr@/.dsi@/.unimi@/.it -> lsr@/.di@/.unimi@/.it

http://code.google.com/p/lilypond/issues/detail?id=3951

[Mark Polesky, 2014-06-13 21:24:34]

I'm seeing some confusion on -user due to the broken LSR links.  Here's an
(unavoidably large) patch to fix the links.

- Mark

[lemzwerg, 2014-06-13 21:28:39]

Yeah!  I've just uploaded an update to Sebastiano's `cd' package for LaTeX, and
I was also bitten by the change of his e-mail address...

AFAIK, the URL change is out of Sebastiano's control.

Thanks for working on this.

[lemzwerg, 2014-06-13 21:29:38]

[I mean `uploaded' to CTAN, of course – this is not related to lilypond.]

[pkx166h, 2014-06-14 09:43:59]

I am not sure this is the best/correct method for the snippets. Shouldn't you be
editing those in ../snippets/new/.. and then using makelsr.py to 'update' the
snippets in the usual way? Else if someone comes and edits a snippet in new
*after* this patch, all your work is undone as  the 'new' snippet overwrites the
original one.

I am always a bit sketchy on the snippets process (when I do get it I forget to
document it more coherently in the CG), but I think this won't work.

[mail_philholmes.net, 2014-06-14 10:03:46]

----- Original Message ----- 
From: <pkx166h@gmail.com>
To: <markpolesky@gmail.com>; <lemzwerg@googlemail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Saturday, June 14, 2014 10:43 AM
Subject: Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043 
bymarkpolesky@gmail.com)


>I am not sure this is the best/correct method for the snippets.
> Shouldn't you be editing those in ../snippets/new/.. and then using
> makelsr.py to 'update' the snippets in the usual way? Else if someone
> comes and edits a snippet in new *after* this patch, all your work is
> undone as  the 'new' snippet overwrites the original one.
>
> I am always a bit sketchy on the snippets process (when I do get it I
> forget to document it more coherently in the CG), but I think this won't
> work.
>
> https://codereview.appspot.com/102410043/


I would suggest correcting the links in the Documentation, but not the 
snippets themselves.  The links in the snippets are not really visible 
(commented out) and, as James says, are over-written with an LSR import.

--
Phil Holmes 

[Mark Polesky, 2014-06-14 16:48:51]

On 2014/06/14 10:03:46, mail_philholmes.net wrote:
> I would suggest correcting the links in the Documentation, but not the 
> snippets themselves.  The links in the snippets are not really visible 
> (commented out) and, as James says, are over-written with an LSR import.

Fair enough.  I reverted the edits within the snippets directory, then ran
makelsr.py, which affected only one file:
  Documentation/snippets/defining-an-engraver-in-scheme--ambitus-engraver.ly
All better?

Thanks.
- Mark

[Mark Polesky, 2014-06-18 22:44:40]

Now that this patch is in the git repo, I decided to import the LSR to Git,
following the instructions in CG 7.4:
http://lilypond.org/doc/v2.19/Documentation/contributor/lsr-to-git

However, on the last step (manually checking for unsafe files), it became
abundantly clear that I am *not* the person for that task, and I wouldn't want
to be responsible for some sort of catastrophic security breach, not to mention
the fact that the resulting diff was 5571 lines long.  At that length, it seems
preferable to redirect the output to a file:

  xargs git diff HEAD < lsr-unsafe.txt > tmp

So... if anyone else wants to take that on, don't let me stop you.  :)

- Mark