Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 1014043: code review 1014043: fmt: %T print <nil> for nil (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by cw
Modified:
15 years, 3 months ago
Reviewers:
CC:
r, golang-dev, rsc
Visibility:
Public.

Description

fmt: %T print <nil> for nil

Patch Set 1 #

Patch Set 2 : code review 1014043: fmt: %T print <nil> for nil #

Patch Set 3 : code review 1014043: fmt: %T print <nil> for nil #

Patch Set 4 : code review 1014043: fmt: %T print <nil> for nil #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/fmt/print.go View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
cw
Hello r (cc: golang-dev@googlegroups.com, rsc), I'd like you to review this change.
15 years, 3 months ago (2010-04-28 06:53:57 UTC) #1
r
LGTM
15 years, 3 months ago (2010-04-28 17:35:34 UTC) #2
r
actually on second thought, please add a test for this case.
15 years, 3 months ago (2010-04-28 17:36:44 UTC) #3
cw
Hello r (cc: golang-dev@googlegroups.com, rsc), Please take another look.
15 years, 3 months ago (2010-04-28 20:05:41 UTC) #4
r
LGTM
15 years, 3 months ago (2010-04-28 20:06:44 UTC) #5
r
15 years, 3 months ago (2010-04-28 20:07:23 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=10f1d61c7cb6 ***

fmt: %T print <nil> for nil

R=r
CC=golang-dev, rsc
http://codereview.appspot.com/1014043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b