Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(223)

Issue 1008: Issue navigation bar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
18 years ago by Andi
Modified:
16 years, 10 months ago
Reviewers:
GvR
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This patch set removes issue related navigation links (not review related!) from the body and adds a new navigation bar at the top. I think it improves usability and gives a more consistent look to have all these navigation links present when viewing issue related pages. At the moment there are some pages, e.g. edit issue, where's no link back to the issue.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
templates/base.html View 1 chunk +21 lines, -0 lines 0 comments Download
templates/diff.html View 1 chunk +0 lines, -5 lines 0 comments Download
templates/issue.html View 1 chunk +2 lines, -16 lines 0 comments Download

Messages

Total messages: 3
GvR
Not bad, but I think you can go even further. The "Start review" link should ...
18 years ago (2008-05-19 02:06:48 UTC) #1
GvR
[removing an alias]
18 years ago (2008-05-23 19:07:36 UTC) #2
GvR
18 years ago (2008-05-27 22:42:46 UTC) #3
I'm still trying to like this, but I think it needs some more refinement.  E.g.
it's ugly to see the issue title show up twice when viewing the issue or edit
page, and likewise to see the edit link appear on the edit page or the publish
link on the publish page.

I wonder if what we really need is some kind of navigation side bar, instead of
the menu at the top...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b