Issue navigation bar - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments






	Comment editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1008: Issue navigation bar (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 months, 1 week ago by aalbrecht

Modified:
1 month, 4 weeks ago

Reviewers:
GvR

SVN Base:
http://rietveld.googlecode.com/svn/trunk/

Description

This patch set removes issue related navigation links (not review related!) from
the body and adds a new navigation bar at the top.

I think it improves usability and gives a more consistent look to have all these
navigation links present when viewing issue related pages. At the moment there
are some pages, e.g. edit issue, where's no link back to the issue.

Patch Set 1

Created: 2 months, 1 week ago

Download raw patch set

Raw unified diffs	Stats		Side-by-side diffs with inline comments
templates/base.html	1 chunk	33 lines	0 comments
templates/diff.html	1 chunk	16 lines	0 comments
templates/issue.html	1 chunk	34 lines	0 comments

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

I'm still trying to like this, but I think it needs some more refinement.  E.g.
it's ugly to see the issue title show up twice when viewing the issue or edit
page, and likewise to see the edit link appear on the edit page or the publish
link on the publish page.

I wonder if what we really need is some kind of navigation side bar, instead of
the menu at the top...

Expand All Messages | Collapse All Messages