Code review - Issue 68960047: Require log submitters to verify SCTshttps://codereview.appspot.com/2014-05-08T14:27:23+00:00rietveld
Message from unknown
2014-03-04T15:45:24+00:00Eranurn:md5:75cd0c9ab34f61f9e23b52a29c103cbd
Message from eranm@google.com
2014-03-04T15:47:30+00:00Eranurn:md5:ab0329817757f12c31b993bd03a3ff55
Added language suggested in ticket #2 (http://trac.tools.ietf.org/wg/trans/trac/ticket/2), removed language about submitters not being required to verify the SCT, clarified that log clients which do *not* use the returned SCT should be forward-compatible.
Message from benl@google.com
2014-03-06T16:22:33+00:00Ben Laurie (Google)urn:md5:b84182ec5cc3291e40c9d4772ea30589
https://codereview.appspot.com/68960047/diff/1/doc/rfc6962-bis.xml
File doc/rfc6962-bis.xml (right):
https://codereview.appspot.com/68960047/diff/1/doc/rfc6962-bis.xml#newcode979
doc/rfc6962-bis.xml:979: Submitters submit certificates or Precertificates to the log as described above. They may go on to use the returned SCT to construct a certificate or use it directly in a TLS handshake. Log clients who request an SCT for inclusion in a certificate or during TLS handshakes SHOULD verify it.
Perhaps make it clear that it may not be the log client who does the including?
Message from unknown
2014-05-02T10:39:36+00:00Eranurn:md5:8e27f912e7042bf478532d1f7ee88cf5
Message from eranm@google.com
2014-05-02T10:39:59+00:00Eranurn:md5:514f0916bdcdc9e11ce7dc8971d47f9a
PTAL.
https://codereview.appspot.com/68960047/diff/1/doc/rfc6962-bis.xml
File doc/rfc6962-bis.xml (right):
https://codereview.appspot.com/68960047/diff/1/doc/rfc6962-bis.xml#newcode979
doc/rfc6962-bis.xml:979: Submitters submit certificates or Precertificates to the log as described above. They may go on to use the returned SCT to construct a certificate or use it directly in a TLS handshake. Log clients who request an SCT for inclusion in a certificate or during TLS handshakes SHOULD verify it.
On 2014/03/06 16:22:33, Ben Laurie (Google) wrote:
> Perhaps make it clear that it may not be the log client who does the including?
Done.
Message from unknown
2014-05-02T12:23:43+00:00Eranurn:md5:738b1bbf7cc7321214db66666acfc4a6
Message from benl@google.com
2014-05-07T13:23:48+00:00Ben Laurie (Google)urn:md5:81ef79dbc3a0c222bd3b757ec56c0a61
LGTM
Message from eranm@google.com
2014-05-08T14:27:23+00:00Eranurn:md5:93f27f6f11f95ec30d9c53536bcb357f
On 2014/05/07 13:23:48, Ben Laurie (Google) wrote:
> LGTM
Pushed as https://code.google.com/p/certificate-transparency/source/detail?r=41f38c0c3ea0726fc5080834a801eaf1a4f677eb and https://code.google.com/p/certificate-transparency/source/detail?r=0318af9954e760faedfd1098f6b8cdf9e804286c.