Code review - Issue 6847101: code review 6847101: net/http/httptest: protect against port reusehttps://codereview.appspot.com/2012-11-25T23:23:25+00:00rietveld
Message from unknown
2012-11-25T19:57:39+00:00bradfitzurn:md5:bd1bb2e8ba256da69aa224efd1567e32
Message from unknown
2012-11-25T19:57:43+00:00bradfitzurn:md5:5d28303be078dd2606bfeb4477227359
Message from unknown
2012-11-25T19:57:47+00:00bradfitzurn:md5:21aa8b35371d8ac21db83dc921aea81d
Message from bradfitz@golang.org
2012-11-25T19:57:51+00:00bradfitzurn:md5:45c0b439b4f669256dd7047997869d71
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from minux.ma@gmail.com
2012-11-25T20:06:10+00:00minux1urn:md5:0670c10261ee24d078bdcafbe55e0238
https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go
File src/pkg/net/http/httptest/server.go (right):
https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go#newcode159
src/pkg/net/http/httptest/server.go:159: if t, ok := http.DefaultTransport.(*http.Transport); ok {
if we tie this closely to http.DefaultTransport, maybe we need
an extra note to remind users of custom RoundTripper to close
idle connections (if any) themselves in order to avoid this problem.
Message from bradfitz@golang.org
2012-11-25T20:12:43+00:00bradfitzurn:md5:86586460ec2527ea992028626c218e97
People who make their own Transports are fine: they'll have their own
connection cache never to be shared.
We only need to care about users of DefaultTransport.
On Nov 25, 2012 12:06 PM, <minux.ma@gmail.com> wrote:
>
> https://codereview.appspot.**com/6847101/diff/5001/src/pkg/**
> net/http/httptest/server.go<https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go>
> File src/pkg/net/http/httptest/**server.go (right):
>
> https://codereview.appspot.**com/6847101/diff/5001/src/pkg/**
> net/http/httptest/server.go#**newcode159<https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go#newcode159>
> src/pkg/net/http/httptest/**server.go:159: if t, ok :=
> http.DefaultTransport.(*http.**Transport); ok {
> if we tie this closely to http.DefaultTransport, maybe we need
> an extra note to remind users of custom RoundTripper to close
> idle connections (if any) themselves in order to avoid this problem.
>
> https://codereview.appspot.**com/6847101/<https://codereview.appspot.com/6847101/>
>
Message from minux.ma@gmail.com
2012-11-25T20:27:06+00:00minux1urn:md5:0a976952cef6775347bc489fc3b7d79e
LGTM.
Message from unknown
2012-11-25T23:23:17+00:00bradfitzurn:md5:58d6882f7f59ef854dab10c2b490d4ef
Message from bradfitz@golang.org
2012-11-25T23:23:25+00:00bradfitzurn:md5:8290389aa8d14e22a30abf93547b8f43
*** Submitted as http://code.google.com/p/go/source/detail?r=cd3ad8805953 ***
net/http/httptest: protect against port reuse
Should make BSDs more reliable. (they seem to reuse ports
quicker than Linux)
Tested by hand with local modifications to force reuse on
Linux. (net/http tests failed before, pass now) Details in the
issue.
Fixes issue 4436
R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6847101