Code review - Issue 6564054: state: make Refresh return NotFoundErrorhttps://codereview.appspot.com/2012-09-26T14:21:56+00:00rietveld
Message from unknown
2012-09-26T13:32:22+00:00rogurn:md5:3ca8a2ddb596fede04458ce95b92b2ad
Message from rogpeppe@gmail.com
2012-09-26T13:32:30+00:00rogurn:md5:45c144f790726a3dfee49e7ae8465a11
Please take a look.
Message from unknown
2012-09-26T13:43:45+00:00rogurn:md5:e3998a11e8065513536ab4cdc3f152a0
Message from rogpeppe@gmail.com
2012-09-26T13:43:47+00:00rogurn:md5:a4a9bd681c1d2c9fee983e8cbd5e7541
Please take a look.
Message from n13m3y3r@gmail.com
2012-09-26T14:10:10+00:00niemeyerurn:md5:28a1504d314da7c9520c10953e4c418e
Good catch. LGTM with the trivials:
https://codereview.appspot.com/6564054/diff/3001/state/machine_test.go
File state/machine_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/machine_test.go#newcode160
state/machine_test.go:160: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
c.Assert(state.IsNotFound(err), Equals, true)
https://codereview.appspot.com/6564054/diff/3001/state/relation.go
File state/relation.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/relation.go#newcode109
state/relation.go:109: return notFound("relation %v", r)
s/%v/%q/
https://codereview.appspot.com/6564054/diff/3001/state/relation_test.go
File state/relation_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/relation_test.go#newcode145
state/relation_test.go:145: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
c.Assert(state.IsNotFound(err), Equals, true)
https://codereview.appspot.com/6564054/diff/3001/state/service.go
File state/service.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/service.go#newcode144
state/service.go:144: return notFound("service %v", s)
s/%v/%q/
https://codereview.appspot.com/6564054/diff/3001/state/service_test.go
File state/service_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/service_test.go#newcode71
state/service_test.go:71: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
c.Assert(state.IsNotFound(err), Equals, true)
https://codereview.appspot.com/6564054/diff/3001/state/unit_test.go
File state/unit_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/unit_test.go#newcode82
state/unit_test.go:82: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
c.Assert(state.IsNotFound(err), Equals, true)
Message from unknown
2012-09-26T14:18:45+00:00rogurn:md5:0ef639ddb60c299ec94061399ba373a9
Message from unknown
2012-09-26T14:21:31+00:00rogurn:md5:61e106c73cf3fa4def88410d65c7ee4a
Message from rogpeppe@gmail.com
2012-09-26T14:21:56+00:00rogurn:md5:3d5eb91b12bb322bc085c953afa26a56
*** Submitted:
state: make Refresh return NotFoundError
Make Refresh return NotFoundError when the entity being
refreshed has been deleted.
R=niemeyer
CC=
https://codereview.appspot.com/6564054
https://codereview.appspot.com/6564054/diff/3001/state/machine_test.go
File state/machine_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/machine_test.go#newcode160
state/machine_test.go:160: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
On 2012/09/26 14:10:10, niemeyer wrote:
> c.Assert(state.IsNotFound(err), Equals, true)
Done.
https://codereview.appspot.com/6564054/diff/3001/state/relation.go
File state/relation.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/relation.go#newcode109
state/relation.go:109: return notFound("relation %v", r)
On 2012/09/26 14:10:10, niemeyer wrote:
> s/%v/%q/
Done.
https://codereview.appspot.com/6564054/diff/3001/state/relation_test.go
File state/relation_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/relation_test.go#newcode145
state/relation_test.go:145: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
On 2012/09/26 14:10:10, niemeyer wrote:
> c.Assert(state.IsNotFound(err), Equals, true)
Done.
https://codereview.appspot.com/6564054/diff/3001/state/service.go
File state/service.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/service.go#newcode144
state/service.go:144: return notFound("service %v", s)
On 2012/09/26 14:10:10, niemeyer wrote:
> s/%v/%q/
Done.
https://codereview.appspot.com/6564054/diff/3001/state/service_test.go
File state/service_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/service_test.go#newcode71
state/service_test.go:71: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
On 2012/09/26 14:10:10, niemeyer wrote:
> c.Assert(state.IsNotFound(err), Equals, true)
Done.
https://codereview.appspot.com/6564054/diff/3001/state/unit_test.go
File state/unit_test.go (right):
https://codereview.appspot.com/6564054/diff/3001/state/unit_test.go#newcode82
state/unit_test.go:82: c.Assert(err, FitsTypeOf, &state.NotFoundError{})
On 2012/09/26 14:10:10, niemeyer wrote:
> c.Assert(state.IsNotFound(err), Equals, true)
Done.