Code review - Issue 5498079: Ported launcher-gtk.py to GObject Introspectionhttps://codereview.appspot.com/2011-12-28T13:50:54+00:00rietveld
Message from unknown
2011-12-23T10:33:05+00:00nicoeurn:md5:e680ccc18c003147a2fed820c1e83067
Message from nicolas.evrard@b2ck.com
2011-12-23T10:33:08+00:00nicoeurn:md5:cd541698619e08fd24c504b7d53bcfaf
Message from nicolas.evrard@b2ck.com
2011-12-23T10:45:24+00:00nicoeurn:md5:a44f783678353dbd59c26573444277c1
http://codereview.appspot.com/5498079/diff/1/demos/launcher-gtk.py
File demos/launcher-gtk.py (right):
http://codereview.appspot.com/5498079/diff/1/demos/launcher-gtk.py#newcode6
demos/launcher-gtk.py:6: GtkClutter.init([]) # Must be initialized before importing those:
Otherwise drag and dropping the map, using the scroll to zoom does not work.
http://codereview.appspot.com/5498079/diff/1/demos/launcher-gtk.py#newcode48
demos/launcher-gtk.py:48: self.path_layer.add_node(Champlain.Coordinate.new_full(45.4095,
Would it be possible to use Champlain.Coordinate(45, -73) instead of using a constructor ? It would made the binding more pythonic.
http://codereview.appspot.com/5498079/diff/1/demos/launcher-gtk.py#newcode144
demos/launcher-gtk.py:144: #self.view.set_property("map-source", source)
I think Jiri told me that it is fixed with the new version but I havent compiled it.
Message from unknown
2011-12-28T13:50:52+00:00nicoeurn:md5:db7c28ef0acef89c4df8f4e10ae12e56
Message from nicolas.evrard@b2ck.com
2011-12-28T13:50:54+00:00nicoeurn:md5:f0469c045f7772c5d2aa37ecc8f89f36