Code review - Issue 5414043: Uploading Bigquery example App Engine dashboardhttps://codereview.appspot.com/2011-11-21T19:24:30+00:00rietveld
Message from unknown
2011-11-17T23:02:07+00:00lparkinsonurn:md5:19b51126e9a462c9c979f933c0b63eda
Message from lparkinson@google.com
2011-11-17T23:02:18+00:00lparkinsonurn:md5:6b52a134de3d9c4c3df74ca60eb82178
Message from rmistry@google.com
2011-11-20T16:03:41+00:00rmistryurn:md5:3e1a60734aded97d651f2180bb1f3444
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json
File bigquery-appengine-sample/src/main/resources/client_secrets.json (right):
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json#newcode1
bigquery-appengine-sample/src/main/resources/client_secrets.json:1: {
In the samples repository we have client_secrets.json files stored in shared projects. Can you instead please use the client_secrets file from
http://code.google.com/p/google-api-java-client/source/browse/?repo=samples#hg%2Fshared%2Fshared-sample-appengine%2Fsrc%2Fmain%2Fresources%253Fstate%253Dclosed
You will also need to update the pom.xml (to add the new dependency) and instructions.html (to add mvn source:jar install on the shared appengine project).
Message from rmistry@google.com
2011-11-20T16:06:35+00:00rmistryurn:md5:0fbd1dda1cf0ed84e2d6a24ba46c0a18
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json
File bigquery-appengine-sample/src/main/resources/client_secrets.json (right):
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json#newcode1
bigquery-appengine-sample/src/main/resources/client_secrets.json:1: {
On 2011/11/20 16:03:42, rmistry wrote:
> In the samples repository we have client_secrets.json files stored in shared
> projects. Can you instead please use the client_secrets file from
>
> http://code.google.com/p/google-api-java-client/source/browse/?repo=samples#hg%252Fshared%252Fshared-sample-appengine%252Fsrc%252Fmain%252Fresources%25253Fstate%25253Dclosed
>
> You will also need to update the pom.xml (to add the new dependency) and
> instructions.html (to add mvn source:jar install on the shared appengine
> project).
Oops, the correct link is: http://code.google.com/p/google-api-java-client/source/browse/?repo=samples#hg%2Fshared%2Fshared-sample-appengine%2Fsrc%2Fmain%2Fresources
Message from unknown
2011-11-21T19:03:58+00:00lparkinsonurn:md5:b9f9d210d0f2fafa50446cb2370a6e53
Message from lparkinson@google.com
2011-11-21T19:04:01+00:00lparkinsonurn:md5:f56042f1f070c36602ff640486f9a032
Message from unknown
2011-11-21T19:04:56+00:00lparkinsonurn:md5:57d6243826dd4759447d3794993ce180
Message from lparkinson@google.com
2011-11-21T19:04:58+00:00lparkinsonurn:md5:ea9c9ea3d8c0ee1330552d846aa4211e
Message from rmistry@google.com
2011-11-21T19:13:42+00:00rmistryurn:md5:b65aa784c206b6b931888ea71a87cff6
http://codereview.appspot.com/5414043/diff/9001/bigquery-appengine-sample/pom.xml
File bigquery-appengine-sample/pom.xml (right):
http://codereview.appspot.com/5414043/diff/9001/bigquery-appengine-sample/pom.xml#newcode86
bigquery-appengine-sample/pom.xml:86: <artifactId>shared-sample-gdata</artifactId>
Do you need this dependency?
Message from unknown
2011-11-21T19:18:21+00:00lparkinsonurn:md5:c98f31743f2435519dedf33fc87048c3
Message from lparkinson@google.com
2011-11-21T19:18:35+00:00lparkinsonurn:md5:255ad3d3a27d2353bf50ea2f05f9268d
Message from rmistry@google.com
2011-11-21T19:24:30+00:00rmistryurn:md5:ec5e7db698d3d4401aeba4cebb8a0da7
LGTM