Code review - Issue 5339043: parser.yy: allow postevents in function arguments in generalhttps://codereview.appspot.com/2011-11-08T23:09:30+00:00rietveld
Message from unknown
2011-11-05T09:53:29+00:00dakurn:md5:97a6aa08c6cfe8e5145d783b68e9b0a9
Message from pkx166h@gmail.com
2011-11-05T11:54:16+00:00pkx166hurn:md5:995ed0acbe7068e0aa5433f389b9ac3d
Patch fails to apply to current master
--snip--
jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 < ../Desktop/issue5339043_1.diff
patching file lily/parser.yy
Hunk #1 succeeded at 426 (offset -38 lines).
Hunk #2 succeeded at 460 (offset -46 lines).
Hunk #3 succeeded at 1221 with fuzz 2 (offset -56 lines).
Hunk #4 FAILED at 1305.
Hunk #5 FAILED at 1416.
Hunk #6 FAILED at 1476.
Hunk #7 FAILED at 2018.
Hunk #8 succeeded at 2158 (offset -166 lines).
4 out of 8 hunks FAILED -- saving rejects to file lily/parser.yy.rej
James
Message from dak@gnu.org
2011-11-05T12:02:34+00:00dakurn:md5:a6b94ff227f93f9fa62f4a9e419bfa82
On 2011/11/05 11:54:16, J_lowe wrote:
> Patch fails to apply to current master
Hardly surprising. This is why it says right at the top "This change is on top of the dev/syntax branch still in review." and why its related issue 2018 is blocked on issue 2001.
I'd appreciate testing, but would not lose sleep over it. At the current point of time, comments might be more important.
Message from unknown
2011-11-08T22:08:09+00:00dakurn:md5:dcd74f1f4c71e25e3d770cce9d75a52a
Message from pkx166h@gmail.com
2011-11-08T23:09:30+00:00pkx166hurn:md5:44c346f5f436c348d2dd48c49a53c534
passes make and no reg tests diffs.
james