Code review - Issue 5240054: CG: clarify git-cl and contributor quick starthttps://codereview.appspot.com/2011-10-11T17:39:08+00:00rietveld
Message from unknown
2011-10-11T17:27:03+00:00Graham Percival (old account)urn:md5:99b1634842fd699443313f3e4e4b05af
Message from percival.music.ca@gmail.com
2011-10-11T17:33:41+00:00Graham Percival (old account)urn:md5:cdc6e8fc7ba910125b097350ba507961
Patchy the autobot will ok this in an hour or so, but please take a quick look. Not because I think there's any problems, but because it could bring you up to speed on the new git-cl if you're feeling confused.
Message from bordage.bertrand@gmail.com
2011-10-11T17:34:43+00:00Bertrand Bordageurn:md5:f88e8a7e835edb27890927bf9589629a
LGTM
http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953
Documentation/contributor/source-code.itexi:953: Note that a google account need not be a gmail account; you can
"doesn't need to be a gmail account"?
Message from unknown
2011-10-11T17:37:22+00:00Graham Percival (old account)urn:md5:ec236d3564c6e8cb2fcadc5fe8c7242b
Message from percival.music.ca@gmail.com
2011-10-11T17:39:08+00:00Graham Percival (old account)urn:md5:ebbd4e2e4ed15d1424348c43fcc5a8c7
http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953
Documentation/contributor/source-code.itexi:953: Note that a google account need not be a gmail account; you can
On 2011/10/11 17:34:43, Bertrand Bordage wrote:
> "doesn't need to be a gmail account"?
My version was not incorrect by the rules of formal English grammar, but it could certainly sound weird to non-native speakers. I've made the change you suggested, thanks!