Code review - Issue 4968056: setup.py for medicalhttps://codereview.appspot.com/2011-10-22T15:37:09+00:00rietveld
Message from unknown
2011-09-01T02:59:08+00:00zodmanurn:md5:543ceb94443d431b31268055381627fd
Message from unknown
2011-09-01T03:37:11+00:00zodmanurn:md5:b1e6771916c9e23c69e408b5f10b62ab
Message from unknown
2011-09-01T04:13:30+00:00zodmanurn:md5:75ecc9752fd2b037082378d7de4fd46b
Message from cedric.krier@b2ck.com
2011-09-01T07:28:07+00:00cedurn:md5:09501f72bdf329aac1fb1aeee6dd7cfa
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py
File __tryton__.py (right):
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py#newcode12
__tryton__.py:12: 'reports': [
It is not used in Tryton
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py#newcode19
__tryton__.py:19: 'icons':[
This keyword doesn't exist in Tryton
https://codereview.appspot.com/4968056/diff/3001/setup.py
File setup.py (right):
https://codereview.appspot.com/4968056/diff/3001/setup.py#newcode23
setup.py:23: version=info.get('version', '1.3.1'),
Strange to have 2 different version numbers.
https://codereview.appspot.com/4968056/diff/3001/setup.py#newcode28
setup.py:28: download_url="http://downloads.tryton.org/" + \
wrong url
Message from zodman@gmail.com
2011-09-01T14:27:26+00:00zodmanurn:md5:22a90481bbaa67b6564910370f4af66c
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py
File __tryton__.py (right):
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py#newcode12
__tryton__.py:12: 'reports': [
On 2011/09/01 07:28:07, ced wrote:
> It is not used in Tryton
Yes need change i seen how add icons and others data from tryton_products. Thanks for the review
https://codereview.appspot.com/4968056/diff/3001/__tryton__.py#newcode19
__tryton__.py:19: 'icons':[
On 2011/09/01 07:28:07, ced wrote:
> This keyword doesn't exist in Tryton
Yes need change i seen how add icons and others data from tryton_products. Thanks for the review
Message from zodman@gmail.com
2011-09-01T14:29:46+00:00zodmanurn:md5:ad0ca32199211d826314d2ca73d46c69
https://codereview.appspot.com/4968056/diff/3001/setup.py
File setup.py (right):
https://codereview.appspot.com/4968056/diff/3001/setup.py#newcode23
setup.py:23: version=info.get('version', '1.3.1'),
On 2011/09/01 07:28:07, ced wrote:
> Strange to have 2 different version numbers.
Yes it because the module on __tryton__,oy have the 0.0.1 and on original setup.py the version as '1.0.0', i change it because last release of medical is 1.3.1 But break when run setuptools trying to download a old version of trytond
https://codereview.appspot.com/4968056/diff/3001/setup.py#newcode28
setup.py:28: download_url="http://downloads.tryton.org/" + \
On 2011/09/01 07:28:07, ced wrote:
> wrong url
Health not have a unique download url by package.I think need discuss it.
Message from unknown
2011-09-02T15:10:13+00:00zodmanurn:md5:7ef88a069b06a8a1e7b3c9349fbd1da2
Message from unknown
2011-09-02T15:35:06+00:00zodmanurn:md5:fe88918b0f5589b7f1fdb958c1b82367
Message from cedric.krier@b2ck.com
2011-10-22T15:37:09+00:00cedurn:md5:9461df1001bc740a327718b4c81b6fe8
Can be closed