Code review - Issue 4442083: rest-collision.cc: adjust all rests in column. Issues 1618 and 1547https://codereview.appspot.com/2011-04-30T21:30:04+00:00rietveld
Message from unknown
2011-04-26T00:39:19+00:00Keithurn:md5:39b40e508df720059649746c3aa48c22
Message from unknown
2011-04-26T04:30:16+00:00Keithurn:md5:fe838cc28755da288c2e05fae6783495
Message from k-ohara5a5a@oco.net
2011-04-26T04:41:50+00:00Keithurn:md5:a17987f623f960c43b34aed0943708ac
It was tempting to resolve all collisions, as is already done when there are only rests, but given the tricky data dependencies (see discussion of issue 1031) I should keep the bug-fix commit as safe and simple as possible.
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc
File lily/rest-collision.cc (right):
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc#newcode208
lily/rest-collision.cc:208: {
Unindented the for loop to avoid trivial whitespace changes that destroy the diff synchronization. My editor will re-indent. If you want to comment on indentation, refer to patch set 1.
Message from percival.music.ca@gmail.com
2011-04-28T12:20:49+00:00Graham Percival (old account)urn:md5:e73e178b4d0205aa69697949ae1e14b7
LTGM, and regtests are fine.
Message from Carl.D.Sorensen@gmail.com
2011-04-30T14:46:51+00:00Carlurn:md5:d2b64f41fd6a619e80cbe80a32393a8e
LGTM. A couple of non-essential comments.
http://codereview.appspot.com/4442083/diff/12001/input/regression/rest-polyphonic-2.ly
File input/regression/rest-polyphonic-2.ly (right):
http://codereview.appspot.com/4442083/diff/12001/input/regression/rest-polyphonic-2.ly#newcode5
input/regression/rest-polyphonic-2.ly:5: result in collision, but is supressed if the rest has a pitch."
The texidoc should have a statement that describes what the output should look like.
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc
File lily/rest-collision.cc (right):
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc#newcode281
lily/rest-collision.cc:281: "Move around ordinary rests (not multi-measure-rests) to avoid"
Perhaps include pitched rests along with mult-measure-rests in the description of rests not affected by this interface.
Message from unknown
2011-04-30T21:30:04+00:00Keithurn:md5:027cc9daebc33433fb74cd28ba0a4b58