Code review - Issue 4174055: code review 4174055: build: reduce the use of subshells in recursive makehttps://codereview.appspot.com/2011-02-18T23:49:52+00:00rietveld
Message from unknown
2011-02-17T04:30:03+00:00dfcurn:md5:5c7681e3c61899f342362d938281fba4
Message from unknown
2011-02-17T04:30:10+00:00dfcurn:md5:7eccbe0c102a8f82972ad8dec0dc5083
Message from unknown
2011-02-17T04:31:36+00:00dfcurn:md5:71556cb534b8f204dbd38268ca919e36
Message from dave@cheney.net
2011-02-17T04:31:48+00:00dfcurn:md5:5a5c89816823967757acc713c74bde87
Hello adg (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from rsc@golang.org
2011-02-17T04:35:31+00:00rscurn:md5:68be123c50b9b85b9960ed72163be9cd
sigh
> There are other places in the distribution src/make.common for example
> that could also benefit from this change.
please add those to this CL too
thanks.
russ
Message from unknown
2011-02-17T04:42:11+00:00dfcurn:md5:7f438f2231302c70aabbc3f538f008aa
Message from dave@cheney.net
2011-02-17T04:42:48+00:00dfcurn:md5:24be11f995e7dcf784796ac46661c5da
Added src/Make.common. Please take another look.
Cheers
Dave
Message from adg@golang.org
2011-02-17T16:59:35+00:00adgurn:md5:b580e0104dbd8964a45aa52d3a9dea11
LGTM
Message from adg@golang.org
2011-02-17T16:59:46+00:00adgurn:md5:fa0564ce95fc259d0e1229ef079e98f6
*** Submitted as 440678ea208a ***
build: reduce the use of subshells in recursive make
Using make -C $* rather than (cd $* ; make) results in a small,
but measurable improvement in build times where compilation is
not the major component. eg.
before - ~/go/src/pkg$ time make
real 0m1.176s
user 0m0.639s
sys 0m0.399s
after - ~/go/src/pkg$ time make
real 0m0.916s
user 0m0.571s
sys 0m0.243s
There are other places in the distribution src/make.common for example
that could also benefit from this change.
R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/4174055
Committer: Andrew Gerrand <adg@golang.org>
Message from adg@golang.org
2011-02-18T23:49:52+00:00adgurn:md5:bda9795e9f06a7ff39d480da059b48a1
*** Submitted as http://code.google.com/p/go/source/detail?r=fa0771258ae1 ***
build: reduce the use of subshells in recursive make
Using make -C $* rather than (cd $* ; make) results in a small,
but measurable improvement in build times where compilation is
not the major component. eg.
before - ~/go/src/pkg$ time make
real 0m1.176s
user 0m0.639s
sys 0m0.399s
after - ~/go/src/pkg$ time make
real 0m0.916s
user 0m0.571s
sys 0m0.243s
There are other places in the distribution src/make.common for example
that could also benefit from this change.
R=adg
CC=golang-dev, rsc
http://codereview.appspot.com/4174055
Committer: Andrew Gerrand <adg@golang.org>