Code review - Issue 4173068: HTTP and SOCKS proxy support for ApacheHttpTranporthttps://codereview.appspot.com/2021-12-09T03:11:17+00:00rietveld
Message from unknown
2011-02-20T03:19:16+00:00viallyurn:md5:3c30ca78353175981db8bd9801dbbf11
Message from vially.ichb@gmail.com
2011-02-20T03:51:50+00:00viallyurn:md5:a7c21595d7dcfdd8c9b94a8f91ecd36f
Patch for issue 114 (http://code.google.com/p/google-api-java-client/issues/detail?id=114)
Message from yanivi@google.com
2011-06-24T11:27:45+00:00yaniviurn:md5:13b3caec7efcf154f7bd810fb2e333bd
Sorry for not responding to your code review!
One concern I have is the dependency on HttpClient 4.1, only because we want ApacheHttpTransport to work on Android and its SDK includes HttpClient 4.0. One possible way to try to resolve this is to start a new Maven module project with the suffix "apache41" and provide a subclass of ApacheHttpTransport41 that extends ApacehHttpTransport and provides an implementation of the proxy methods.
A completely different option is to leave ApacheHttpTransport as it is, but allow the HttpClient to be passed in as a parameter to the constructor. That way you can set up the proxy information in your application any way you want.
The one issue is that we've now split off the HTTP code into its own code.google.com project called google-http-java-client. So please port over to that.
So again thanks for sending the code review, and I apologize for the very long delay. Since there are some design questions, it might be good to start a discussion on the google-api-java-client Google group to get wider feedback from the community of developers. In particular I'd like my coworkers also to take a look.
Message from vially.ichb@gmail.com
2011-07-01T14:50:35+00:00viallyurn:md5:b876cae1d85490bf61c90c792c85f217
Thanks for your response. I'm a little busy with my job right now but hopefully I'll be able to start a discussion on the Google groups page and have another shot at solving it in the next couple of weeks.
Thanks!
On 2011/06/24 11:27:45, yanivi wrote:
> Sorry for not responding to your code review!
>
> One concern I have is the dependency on HttpClient 4.1, only because we want
> ApacheHttpTransport to work on Android and its SDK includes HttpClient 4.0. One
> possible way to try to resolve this is to start a new Maven module project with
> the suffix "apache41" and provide a subclass of ApacheHttpTransport41 that
> extends ApacehHttpTransport and provides an implementation of the proxy methods.
>
> A completely different option is to leave ApacheHttpTransport as it is, but
> allow the HttpClient to be passed in as a parameter to the constructor. That
> way you can set up the proxy information in your application any way you want.
>
> The one issue is that we've now split off the HTTP code into its own
> http://code.google.com project called google-http-java-client. So please port over to
> that.
>
> So again thanks for sending the code review, and I apologize for the very long
> delay. Since there are some design questions, it might be good to start a
> discussion on the google-api-java-client Google group to get wider feedback from
> the community of developers. In particular I'd like my coworkers also to take a
> look.
Message from jinny7845@gmail.com
2015-04-25T12:57:31+00:00jinny7845urn:md5:041d8ddd5b9de487e5165f3f995b28b4
On 2011/06/24 11:27:45, yanivi wrote:
> <font><font>당신의 코드 리뷰에 응답하지 죄송합니다! </font></font><font></font>
> <font></font><font><font>
> 내가 가진 하나의 문제는 우리가 원하는 때문, HttpClient를 4.1에 대한 종속성입니다</font></font><font></font><font><font>
> ApacheHttpTransport 안드로이드에서 작동하고 그 SDK는 HttpClient를 4.0이 포함되어 있습니다. </font><font>하나</font></font><font></font><font><font>
> 이 문제를 해결하려고 할 수 방법에 새로운 메이븐 모듈 프로젝트를 시작하는 것입니다</font></font><font></font><font><font>
> 접미사 "apache41"하고 ApacheHttpTransport41의 서브 클래스를 제공하는</font></font><font></font><font><font>
> ApacehHttpTransport를 확장하고 프록시 방식의 구현을 제공합니다.</font></font><font></font>
> <font></font><font><font>
> 완전히 다른 옵션은 그대로 ApacheHttpTransport을 떠나야하지만,</font></font><font></font><font><font>
> 수 HttpClient를 생성자에 매개 변수로 전달합니다. </font><font>그</font></font><font></font><font><font>
> 방법 당신은 당신이 원하는 방식으로 응용 프로그램에서 프록시 정보를 설정할 수 있습니다.</font></font><font></font>
> <font></font><font><font>
> 하나의 문제는 우리가 지금 자신에 HTTP 코드를 분리 한 것입니다</font></font><font></font>
> http://code.google.com<font><font> 프로젝트는 구글-HTTP-자바 클라이언트라고. </font><font>에 걸쳐 그래서하시기 바랍니다 포트</font></font><font></font><font><font>
> 그.</font></font><font></font>
> <font></font><font><font>
> 그래서 다시 코드 리뷰를 보내 주셔서 감사합니다, 나는 매우 긴 사과</font></font><font></font><font><font>
> 지연. </font><font>몇 가지 디자인 문제가 있기 때문에, 그것은을 시작하는 것이 좋을 것</font></font><font></font><font><font>
> 구글-API - 자바 클라이언트 구글 그룹에 대한 토론에서 폭 넓은 의견을 얻을 수 있습니다</font></font><font></font><font><font>
> 개발자의 커뮤니티입니다. </font><font>특히 내가 걸릴 또한 내 동료 싶습니다</font></font><font></font><font><font>
> 봐.</font></font>
> 봐.</font></font>
> 봐.</font></font>
> 봐.</font></font>
Message from belovic.martin@gmail.com
2021-03-01T03:23:36+00:00belovic.martinurn:md5:863dae4fd025da49e619ed0b09806898
4
Message from kristinakussow@gmail.com
2021-12-09T03:10:11+00:00kristinakussowurn:md5:b1db41c246a75317a008be7f5da1513d
Message from kristinakussow@gmail.com
2021-12-09T03:11:17+00:00kristinakussowurn:md5:7bdb697b6558cde9df2f6ee68ca42508
On 2021/12/09 03:10:11, kristinakussow wrote:
1