Code review - Issue 369930043: Change \partcombine (et al.) to \partCombinehttps://codereview.appspot.com/2018-12-29T10:40:36+00:00rietveld
Message from unknown
2018-12-15T01:50:56+00:00Valentin Villenaveurn:md5:7b72aceaa3ea8cd2b4251fe7b165e43a
Message from unknown
2018-12-16T14:31:29+00:00Valentin Villenaveurn:md5:fbd5025211d4115c9eb1ef8132c10cb8
Message from v.villenave@gmail.com
2018-12-16T14:31:45+00:00Valentin Villenaveurn:md5:db742e5f3662ccb2e0777ee5ab10778d
Revamped patch. Passes make & makedoc; adds \autoChange.
Message from dak@gnu.org
2018-12-21T11:22:21+00:00dakurn:md5:8d0291e50390f9575ad8d82f95664035
https://codereview.appspot.com/369930043/diff/20001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/369930043/diff/20001/python/convertrules.py#newcode3977
python/convertrules.py:3977: str = re.sub (r"\\partcombine", r"\\partCombine", str)
Uh, you realize that every line after this one is a no-op?
Message from unknown
2018-12-21T17:50:24+00:00Valentin Villenaveurn:md5:d997267832955cb93abff9e96194196a
Message from v.villenave@gmail.com
2018-12-21T17:50:33+00:00Valentin Villenaveurn:md5:e87012cad4f4f8a75653d82b0da5501b
Correct convert rules.
Message from v.villenave@gmail.com
2018-12-28T09:43:58+00:00Valentin Villenaveurn:md5:7791e757c2126d9234a36b566425e9cf
On 2018/12/21 17:50:33, Valentin Villenave wrote:
> Correct convert rules.
OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.
Message from lilypond@maltemeyn.de
2018-12-28T11:11:50+00:00Malte Meynurn:md5:b8215f61b65e05b3c11c2dc2a430d459
On 2018/12/28 09:43:58, Valentin Villenave wrote:
> On 2018/12/21 17:50:33, Valentin Villenave wrote:
> > Correct convert rules.
>
> OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.
I think you should change the sourceforge issue (https://sourceforge.net/p/testlilyissues/issues/4603/):
• click “Edit” at the top right
• set “Status” to “Fixed”
• unset “Patch”
• set “Labels” to “Fixed_2_21_0”
• mention the commit in the comment section at the bottom and click “Save”
Message from pkx166h@runbox.com
2018-12-29T10:40:36+00:00pkx166h_runbox.comurn:md5:5f482f3fe5a378ff3af6c294a7157e3e
Valentin,
On 28/12/2018 11:11 am, lilypond@maltemeyn.de wrote:
> On 2018/12/28 09:43:58, Valentin Villenave wrote:
>> On 2018/12/21 17:50:33, Valentin Villenave wrote:
>> > Correct convert rules.
>
>> OK, pushed onto staging as 72067b395d947f1349ab8010f0592d45e52b8141.
>
> I think you should change the sourceforge issue
> (https://sourceforge.net/p/testlilyissues/issues/4603/):
> • click “Edit” at the top right
> • set “Status” to “Fixed”
> • unset “Patch”
> • set “Labels” to “Fixed_2_21_0”
> • mention the commit in the comment section at the bottom and click
> “Save”
I did this for you as I was checking all the current trackers/Rietvelds
anyway.
James