Code review - Issue 353870043: Add `TEX` environemnt variable for texi2pdfhttps://codereview.appspot.com/2019-02-04T12:56:50+00:00rietveld
Message from unknown
2019-01-28T12:44:41+00:00trueroadurn:md5:8c554a6e1ea503a9f05305ff666cf07d
Message from lemzwerg@googlemail.com
2019-01-28T21:44:11+00:00lemzwergurn:md5:d2ef13abec6a70640b755cef07cfc699
LGTM, thanks!
Message from knupero@gmail.com
2019-01-28T22:28:31+00:00knuperourn:md5:5e35741374820ca46eed92b1c4e4afef
On 2019/01/28 21:44:11, lemzwerg wrote:
> LGTM, thanks!
I agree, LGTM.
I'll do an strace gub build tomorrow to verify that no hidden use of etex was missed.
If the patch passes the strace test it would be an immediate candidate for both master and stable/2.20.
Message from knupero@gmail.com
2019-01-29T12:20:47+00:00knuperourn:md5:403eb7ba73fd92c68f0165f561a1039c
I reverted pull request #59 on a local branch of gub. In the local lilypond repository I created branch 3538700043 pointing to HEAD of stable/2.20, and added the proposed patch to branch 353870043.
make LILYPOND_REPO_URL=git://golem/lilypond.git LILYPOND_BRANCH=stable/2.20 lilypond
fails again as expected,
make LILYPOND_REPO_URL=git://golem/lilypond.git LILYPOND_BRANCH=353870043 lilypond
builds fine.
So this does not only look good, it's proven to be good ;-)
Thanks, Masamichi!
Message from trueroad@gmail.com
2019-02-04T12:56:50+00:00trueroadurn:md5:dc7693d22352d654c2af12d6eda1af23
I've pushed to staging.
commit 88633ac5cf54db38a07ebacc16e38dcabad6f843
Issue 5469/2: Add `TEX` environemnt variable for texi2pdf
commit e757c642cb86f37ad3d069c9c6eff54360486045
Issue 5469/1: Tweak wrapped lines