Code review - Issue 3432041: difflib handling of missing EOF (Python #2142)https://codereview.appspot.com/2011-03-12T14:04:39+00:00rietveld
Message from unknown
2010-12-02T23:43:12+00:00merwokurn:md5:99ac3fc51ecbd5d9d8ccdac3945776fc
Message from winston@netwok.org
2010-12-02T23:43:13+00:00merwokurn:md5:bb54b09a7e5553d053c697b382ded6fd
Message from winston@netwok.org
2010-12-02T23:48:46+00:00merwokurn:md5:b82d9f7772cb5e5979a620b7782eaca0
http://codereview.appspot.com/3432041/diff/1/Lib/test/test_difflib.py
File Lib/test/test_difflib.py (right):
http://codereview.appspot.com/3432041/diff/1/Lib/test/test_difflib.py#newcode202
Lib/test/test_difflib.py:202: "unexpected diff output:\n-- expected this --\n%s\n"
Current version of unittest prints a diff for free, you can remove the custom error message entirely.
http://codereview.appspot.com/3432041/diff/1/Lib/test/test_difflib.py#newcode235
Lib/test/test_difflib.py:235: run_unittest(TestSFpatches, TestSFbugs, TestOutputFormat, Doctests,\
Please don’t escape newlines, it’s error-prone.
Message from unknown
2011-03-12T14:04:39+00:00merwokurn:md5:87b60caac4bf5c8b35d4d85d760eba63
Message from winston@netwok.org
2011-03-12T14:04:39+00:00merwokurn:md5:ff52e59def16e7cf178ffc28d11736e4
Updated version