Code review - Issue 339950043: plot RTT(with jitters) and scores of 1 nodehttps://codereview.appspot.com/2018-01-03T16:12:22+00:00rietveld
Message from unknown
2017-12-05T15:31:02+00:00xinyueurn:md5:62ba66a9c7066500b2904001b3a2f9f1
Message from unknown
2017-12-08T23:46:59+00:00xinyueurn:md5:547d640c74d72103785be25b5893929f
Message from CynthiaMao122@gmail.com
2017-12-08T23:52:26+00:00xinyueurn:md5:e912acfc25f700b778953bc62a6a2a95
in order to explain the score we got better, take one node as an example to plot score and rtt in one plot.
Message from 01tonythomas@gmail.com
2017-12-09T10:14:05+00:00tonythomasurn:md5:addcb30286192df6cbb7f7e8fbdeee78
Can you reply here with a sample plot you got ?
--
Tony Thomas
https://mediawiki.org/wiki/User:01tonythomas
--
On Sat, Dec 9, 2017 at 12:52 AM, <CynthiaMao122@gmail.com> wrote:
> Reviewers: ,
>
> Message:
> in order to explain the score we got better, take one node as an example
> to plot score and rtt in one plot.
>
> Description:
> minior error
> and fix the timestamp precision in x axis
> BUG=
>
> Please review this at https://codereview.appspot.com/339950043/
>
> Affected files (+121, -26 lines):
> M launch_lx3.py
> M utils/ds_score_plots/extract_data_from_log_file.py
> A utils/ds_score_plots/plot_both_score_jitter.py
> M utils/ds_score_plots/plot_jitter_host_to_host.py
>
>
>
Message from 01tonythomas@gmail.com
2017-12-09T10:21:43+00:00tonythomasurn:md5:8d065f75bfd338ed20705294d3234dcc
Alright. its taking good shape. I saw the result yesterday already, but adjust these things and we are good to go.
https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
File launch_lx3.py (right):
https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
launch_lx3.py:495: # plot_host_to_host_jitter(conf, save_dir=unique_exp_folder)
why do you have commented code here ? If its not required, just remove it.
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py
File utils/ds_score_plots/extract_data_from_log_file.py (right):
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py#newcode23
utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms = float(timestamp_ms)
in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py
File utils/ds_score_plots/plot_both_score_jitter.py (right):
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py#newcode10
utils/ds_score_plots/plot_both_score_jitter.py:10: # parsed_t = datetime.strptime(utc_dt, '%Y-%m-%dT%H:%M:%S.%f')
so you are not parsing time using this anymore ?
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py#newcode82
utils/ds_score_plots/plot_both_score_jitter.py:82: # "y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
remove all commented code please.
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_jitter_host_to_host.py
File utils/ds_score_plots/plot_jitter_host_to_host.py (left):
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_jitter_host_to_host.py#oldcode45
utils/ds_score_plots/plot_jitter_host_to_host.py:45: x_2, y_2 = read_data_to_list(os.path.join(ping_result_dir, "h1.2-s1-data.txt"))
these entire rest of code can be removed by using a for loop and one instance. Like this.
for i in range (1, 4):
x, y = read_data_to_list(os.path.join(ping_result_dir, 'h1.{0}-data.txt'.format(i))
plot_data(x, y, os.path.join(save_dir,'h1.{0}_to_s1_jitter.png'.format(i)), 'jitter level from h1.{0} to s1'.format(i))
simple.
Message from unknown
2017-12-09T19:00:56+00:00xinyueurn:md5:c300f0d5b85cd993feb6590c827bfc23
Message from CynthiaMao122@gmail.com
2017-12-09T19:01:31+00:00xinyueurn:md5:073f09906e0c0a23da77028241452106
https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
File launch_lx3.py (right):
https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
launch_lx3.py:495: # plot_host_to_host_jitter(conf, save_dir=unique_exp_folder)
On 2017/12/09 10:21:43, tonythomas wrote:
> why do you have commented code here ? If its not required, just remove it.
There are different functions, want to test only one function so commented others. They will be back when all other things are done.
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py
File utils/ds_score_plots/extract_data_from_log_file.py (right):
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py#newcode23
utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms = float(timestamp_ms)
On 2017/12/09 10:21:43, tonythomas wrote:
> in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])
Acknowledged.
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py
File utils/ds_score_plots/plot_both_score_jitter.py (right):
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py#newcode82
utils/ds_score_plots/plot_both_score_jitter.py:82: # "y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
On 2017/12/09 10:21:43, tonythomas wrote:
> remove all commented code please.
Done.
Message from david.tomic11@gmail.com
2017-12-09T19:07:03+00:00david.tomic11urn:md5:c4ca52fcb4c76496e45b1678f75940de
On 2017/12/09 19:01:31, xinyue wrote:
> https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
> File launch_lx3.py (right):
>
> https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
> launch_lx3.py:495: # plot_host_to_host_jitter(conf, save_dir=unique_exp_folder)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > why do you have commented code here ? If its not required, just remove it.
>
> There are different functions, want to test only one function so commented
> others. They will be back when all other things are done.
>
> https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py
> File utils/ds_score_plots/extract_data_from_log_file.py (right):
>
> https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extract_data_from_log_file.py#newcode23
> utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms =
> float(timestamp_ms)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])
>
> Acknowledged.
>
> https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py
> File utils/ds_score_plots/plot_both_score_jitter.py (right):
>
> https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot_both_score_jitter.py#newcode82
> utils/ds_score_plots/plot_both_score_jitter.py:82: #
> "y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > remove all commented code please.
>
> Done.
Looks pretty good. I see that its building on Zijies code no?
Message from Liangzijie1437@gmail.com
2017-12-10T22:50:09+00:00Liangzijie1437urn:md5:6b5ad0cfcfdff7498c0be06b5ebc6d4e
https://codereview.appspot.com/339950043/diff/40001/utils/ds_score_plots/plot_jitter_host_to_host.py
File utils/ds_score_plots/plot_jitter_host_to_host.py (left):
https://codereview.appspot.com/339950043/diff/40001/utils/ds_score_plots/plot_jitter_host_to_host.py#oldcode51
utils/ds_score_plots/plot_jitter_host_to_host.py:51:
from h1.2 to s1, h1.2 and to h1.3 should be in the same plot.
the same for from h1.1 and h1.3
Message from unknown
2017-12-12T13:25:55+00:00xinyueurn:md5:41aef3490f686ea02987d4f13da18a19
Message from CynthiaMao122@gmail.com
2017-12-12T13:26:25+00:00xinyueurn:md5:6b65413de9ac4770431442e0cae761f5
Message from CynthiaMao122@gmail.com
2017-12-12T13:26:25+00:00xinyueurn:md5:76bcde216ca87a880ca8a013b09475de
Message from david.tomic11@gmail.com
2017-12-12T14:41:27+00:00david.tomic11urn:md5:b68469ec2d569cee3dcb92458b613ecb
On 2017/12/12 13:26:25, xinyue wrote:
You can create a loop for this instead of manually changing the nodes you read from.
Message from unknown
2018-01-03T16:07:18+00:00xinyueurn:md5:ea328ce2587277d859b25ee9736aed6b
Message from unknown
2018-01-03T16:12:22+00:00xinyueurn:md5:2ca76fa177454aa6e0e8239a31aadb94