Code review - Issue 339480043: [plaso] Added Ubuntu end-to-end tests run script for Jenkinshttps://codereview.appspot.com/2018-05-10T09:09:54+00:00rietveld
Message from joachim.metz@gmail.com
2018-03-31T09:56:22+00:00Joachim Metzurn:md5:0657d7faf0c5f21f7bfe1937956013d9
Message from unknown
2018-03-31T10:05:15+00:00Joachim Metzurn:md5:082e1712b1a7d55c00033dcc25379b27
Message from joachim.metz@gmail.com
2018-03-31T10:05:16+00:00Joachim Metzurn:md5:e912ec329f69dac150ae45439fe783e2
Code updated.
Message from onager@deerpie.com
2018-03-31T10:53:31+00:00onagerurn:md5:59dd93a966dede260da2d8617b4c9171
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh
File config/jenkins/linux/run_end_to_end_tests.sh (right):
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11
config/jenkins/linux/run_end_to_end_tests.sh:11: LOGGING_OPTIONS="--debug --log-file=${RESULTS_DIRECTORY}/log2timeline.log.gz";
Please remove, these need to be set in the test configuration
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode18
config/jenkins/linux/run_end_to_end_tests.sh:18: # Remove old profiling options set in the configuration.
Please remove, these need to be set in the test configuration
Message from joachim.metz@gmail.com
2018-03-31T10:57:17+00:00Joachim Metzurn:md5:208866a3d963de9b8b2f45c32b08ec9c
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh
File config/jenkins/linux/run_end_to_end_tests.sh (right):
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11
config/jenkins/linux/run_end_to_end_tests.sh:11: LOGGING_OPTIONS="--debug --log-file=${RESULTS_DIRECTORY}/log2timeline.log.gz";
this way you don't need to keep updating the configs and we could levels of output with the same configs. Largely that the configs need to be manually edited at the moment.
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode18
config/jenkins/linux/run_end_to_end_tests.sh:18: # Remove old profiling options set in the configuration.
On 2018/03/31 10:53:31, onager wrote:
> Please remove, these need to be set in the test configuration
see previous comment
Message from justzamir@gmail.com
2018-03-31T11:05:35+00:00justzamirurn:md5:5247b562fb43ce1c5dbf0b4d351ba606
On 2018/03/31 10:57:17, Joachim Metz wrote:
> https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh
> File config/jenkins/linux/run_end_to_end_tests.sh (right):
>
> https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11
> config/jenkins/linux/run_end_to_end_tests.sh:11: LOGGING_OPTIONS="--debug
> --log-file=${RESULTS_DIRECTORY}/log2timeline.log.gz";
> this way you don't need to keep updating the configs and we could levels of
> output with the same configs. Largely that the configs need to be manually
> edited at the moment.
>
> https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode18
> config/jenkins/linux/run_end_to_end_tests.sh:18: # Remove old profiling options
> set in the configuration.
> On 2018/03/31 10:53:31, onager wrote:
> > Please remove, these need to be set in the test configuration
>
> see previous comment
https://dragshare.co/gb-instagram-apk-download/
Message from joachim.metz@gmail.com
2018-04-02T07:27:01+00:00Joachim Metzurn:md5:592ef5ab43e60d97357f3353dfffdefa
What about having the configs (at the greendale ones) checked into git as well ?
This way it will be easier to keep them up to date
Message from unknown
2018-04-02T07:52:42+00:00Joachim Metzurn:md5:13451b9a64c568081c2ecdb037d246a7
Message from joachim.metz@gmail.com
2018-04-02T07:52:44+00:00Joachim Metzurn:md5:2e9b887a8f1cd1a31a4617205fdab2a7
Code updated.
Message from joachim.metz@gmail.com
2018-04-02T07:56:45+00:00Joachim Metzurn:md5:4477543c7b4612311c832198a039ffd5
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini
File config/jenkins/greendale/dean.ini (right):
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1
config/jenkins/greendale/dean.ini:1: [dean]
I opt we check in the greendale configs to keep them up to date easier.
Message from joachim.metz@gmail.com
2018-04-02T10:46:23+00:00Joachim Metzurn:md5:ac9a3ec9cb2e63ab885614517cfc8412
Code updated.
Message from joachim.metz@gmail.com
2018-04-02T10:54:36+00:00Joachim Metzurn:md5:0fc1fcb882929d308570def5caf33a86
Code updated.
Message from joachim.metz@gmail.com
2018-04-02T16:06:28+00:00Joachim Metzurn:md5:0e9b6f265a0eb1ed20e2c3135dbaa2b7
Code updated.
Message from joachim.metz@gmail.com
2018-04-06T04:53:40+00:00Joachim Metzurn:md5:ea84ce02a00e180f7de607117d46b16b
Code updated.
Message from onager@deerpie.com
2018-04-07T13:27:00+00:00onagerurn:md5:e6231d8d49372478f3f4986397d513ae
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini
File config/jenkins/greendale/dean.ini (right):
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1
config/jenkins/greendale/dean.ini:1: [dean]
On 2018/04/02 07:56:45, Joachim Metz wrote:
> I opt we check in the greendale configs to keep them up to date easier.
Yes, this in my backlog. I've been focused on getting the tests running and producing data for the moment, though.
Message from onager@deerpie.com
2018-04-07T13:27:01+00:00onagerurn:md5:a6814b52d3025c7d2096534b75deeed3
Message from onager@deerpie.com
2018-04-07T13:27:02+00:00onagerurn:md5:21a20fc1a01b500918ecbd33ddbddc60
Message from joachim.metz@gmail.com
2018-04-07T15:53:53+00:00Joachim Metzurn:md5:d3f1a93a2d40096d62bfd2e42809fdc1
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini
File config/jenkins/greendale/dean.ini (right):
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1
config/jenkins/greendale/dean.ini:1: [dean]
Then I'll add the rest of the configs in this CL.
Message from joachim.metz@gmail.com
2018-04-07T17:21:26+00:00Joachim Metzurn:md5:c25be8b23062ba4a2b9d779226c5f19c
Code updated.
Message from unknown
2018-04-19T13:52:05+00:00Joachim Metzurn:md5:5358951f988987f46c3db5576ff74d71
Message from joachim.metz@gmail.com
2018-04-19T13:52:07+00:00Joachim Metzurn:md5:331f37ea6445230ad389ef732a0ae61b
Code updated.
Message from joachim.metz@gmail.com
2018-04-20T07:44:34+00:00Joachim Metzurn:md5:798dc35fc593284a5d45fa23b632ac67
Code updated.
Message from unknown
2018-05-05T09:01:02+00:00Joachim Metzurn:md5:d327e4d8c20adfb879008ffdde20c152
Message from joachim.metz@gmail.com
2018-05-05T09:01:05+00:00Joachim Metzurn:md5:24e017cf7bc7f4351fc8c37ab6e8b5b8
Code updated.
Message from onager@deerpie.com
2018-05-06T09:39:58+00:00onagerurn:md5:d094dcdcaec82c61e647d653d82d1285
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini
File config/jenkins/greendale/acserver.ini (right):
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini#newcode8
config/jenkins/greendale/acserver.ini:8: profiling_options=--profilers=memory,parsers,processing,serializers,storage,task_queue --profiling_directory=plaso_out/profiling
Please put the the profiling files in "plaso-out", for consistency with existing tests.
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh
File config/jenkins/linux/run_end_to_end_tests.sh (right):
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode15
config/jenkins/linux/run_end_to_end_tests.sh:15: RESULTS_DIRECTORY="plaso_out";
Please keep this as "plaso-out" for consistency with existing tests.
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode42
config/jenkins/linux/run_end_to_end_tests.sh:42: echo "End-to-end tests stared (PID: ${PID_COMMAND})";
started
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode48
config/jenkins/linux/run_end_to_end_tests.sh:48: # On Travis-Ci print the stdout and stderr output to troubleshoot potential issues.
CI
Message from joachim.metz@gmail.com
2018-05-07T05:36:00+00:00Joachim Metzurn:md5:d95b3cc01da4aa93ff20272fcf785983
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini
File config/jenkins/greendale/acserver.ini (right):
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini#newcode8
config/jenkins/greendale/acserver.ini:8: profiling_options=--profilers=memory,parsers,processing,serializers,storage,task_queue --profiling_directory=plaso_out/profiling
please document this in l2tdocs or equiv, including the conventions used.
https://github.com/log2timeline/plaso/issues/1873
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh
File config/jenkins/linux/run_end_to_end_tests.sh (right):
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode15
config/jenkins/linux/run_end_to_end_tests.sh:15: RESULTS_DIRECTORY="plaso_out";
Please document conventions used in jenkins configurations
https://github.com/log2timeline/plaso/issues/1873
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode42
config/jenkins/linux/run_end_to_end_tests.sh:42: echo "End-to-end tests stared (PID: ${PID_COMMAND})";
On 2018/05/06 09:39:58, onager wrote:
> started
Done.
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/linux/run_end_to_end_tests.sh#newcode48
config/jenkins/linux/run_end_to_end_tests.sh:48: # On Travis-Ci print the stdout and stderr output to troubleshoot potential issues.
On 2018/05/06 09:39:58, onager wrote:
> CI
Done.
Message from unknown
2018-05-07T05:40:44+00:00Joachim Metzurn:md5:4218855b305c5083b7492b46edbe78f6
Message from joachim.metz@gmail.com
2018-05-07T05:40:46+00:00Joachim Metzurn:md5:54d2ff680512c7253a81970e970af440
Code updated.
Message from onager@deerpie.com
2018-05-10T08:16:06+00:00onagerurn:md5:8a8e91140745ccf1aec3547895cba769
LGTM
Message from joachim.metz@gmail.com
2018-05-10T09:09:54+00:00Joachim Metzurn:md5:d9d73f5b89f652e4ad4464017efd0cac
Changes have been merged with master branch. To close the review and clean up the feature branch you can run: review.py close jenkins