Code review - Issue 339350043: Use convert -striphttps://codereview.appspot.com/2018-06-03T13:04:40+00:00rietveld
Message from unknown
2018-03-13T10:29:33+00:00bmwiedemannurn:md5:6191997db2d6403c4bd6e67804ee9d0c
Message from dulowiskotic1234@gmail.com
2018-05-29T07:20:04+00:00dulow koticurn:md5:c295a7901ebcc9ffad324737f6b85566
Message from dulowiskotic1234@gmail.com
2018-05-29T07:20:14+00:00dulow koticurn:md5:4233be358074ce1235c1990d243b2e20
On 2018/05/29 07:20:04, dulow kotic wrote:
Message from pkxgnugitcl@runbox.com
2018-06-02T17:51:17+00:00lilypond-pkxurn:md5:34c0ce0d24512e0644dc5a053a580a2c
On 2018/05/29 07:20:14, dulow kotic wrote:
> On 2018/05/29 07:20:04, dulow kotic wrote:
Does this have a relevant 'Tracker issue'? I could not see one.
This is probably why it has been ignored so far, let me know and we can create one for this Rietveld to get it in the Patch review process.
Thanks
James
Message from nine.fierce.ballads@gmail.com
2018-06-02T19:29:16+00:00Dan Ebleurn:md5:e3cf2ac8c713c5582caf43c54872b930
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile
File Documentation/pictures/GNUmakefile (right):
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile#newcode29
Documentation/pictures/GNUmakefile:29: convert -strip -depth 8 -geometry 50x50% $< $@
It would be wise to add a brief comment before the dependency line explaining why -strip is important, otherwise someone might come along later, decide that it is pointless, and remove it.
Are there any undesirable side effects of -strip, for example, removing a copyright notice? The man page says that -strip "strip[s the] image of all profiles and comments" but I'm not familiar enough with convert to know what that means. Are profiles also unimportant here?
Message from bmwiedemann@gmail.com
2018-06-03T13:04:40+00:00bmwiedemannurn:md5:da05af65964a9ad7c910c06b57534767
On 2018/06/02 19:29:16, Dan Eble wrote:
> https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile
> File Documentation/pictures/GNUmakefile (right):
>
> https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile#newcode29
> Documentation/pictures/GNUmakefile:29: convert -strip -depth 8 -geometry 50x50%
> $< $@
> It would be wise to add a brief comment before the dependency line explaining
> why -strip is important, otherwise someone might come along later, decide that
> it is pointless, and remove it.
>
> Are there any undesirable side effects of -strip, for example, removing a
> copyright notice? The man page says that -strip "strip[s the] image of all
> profiles and comments" but I'm not familiar enough with convert to know what
> that means. Are profiles also unimportant here?
Not sure why the tools didnt show it, but this was handled in
https://sourceforge.net/p/testlilyissues/issues/5290/
and merged as commit d1d5f436a190929e38145cf8be7d4fa63b077b46
IMHO, git blame is usually a good tool to find out on why something was added
and I don't think -strip removes important information in this case.