Code review - Issue 330540043: [plaso] Fix for output option parsing. Fixes #1437 #1433https://codereview.appspot.com/2017-10-17T14:58:38+00:00rietveld
Message from unknown
2017-10-11T21:57:39+00:00onagerurn:md5:54b9354f0fb6e5b1a03e89c44f66dbda
Message from onager@deerpie.com
2017-10-11T21:57:43+00:00onagerurn:md5:0d69178002407a0bb0d2d2117527f4bd
Message from aaronp@gmail.com
2017-10-15T05:32:53+00:00aaronpurn:md5:50c86b00c6625a7490e25944d0f4e715
LGTM
Message from joachim.metz@gmail.com
2017-10-15T05:58:07+00:00Joachim Metzurn:md5:41d648aaa29c6ef62c2b19f943026d92
a couple of small things to consider before merge
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py
File plaso/cli/psteal_tool.py (right):
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502
plaso/cli/psteal_tool.py:502: if self._preferred_language == 'list':
please check / rebase with current head
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode529
plaso/cli/psteal_tool.py:529:
nit
- white line
Message from onager@deerpie.com
2017-10-17T13:59:36+00:00onagerurn:md5:cb7b68de1cff0a424d3ea2c7f436b76b
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py
File plaso/cli/psteal_tool.py (right):
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502
plaso/cli/psteal_tool.py:502: if self._preferred_language == 'list':
On 2017/10/15 05:58:07, Joachim Metz wrote:
> please check / rebase with current head
Done.
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode529
plaso/cli/psteal_tool.py:529:
On 2017/10/15 05:58:07, Joachim Metz wrote:
> nit
> - white line
Done.
Message from onager@deerpie.com
2017-10-17T14:58:38+00:00onagerurn:md5:f704a9a5000fa316f3c8aa51811bcaab
Changes have been merged with master branch. To close the review and clean up the feature branch you can run: python ./utils/review.py close fix_args