Code review - Issue 316530043: [dfdatetime] Updated utility scriptshttps://codereview.appspot.com/2017-04-22T09:55:33+00:00rietveld
Message from unknown
2017-04-19T20:37:26+00:00Joachim Metzurn:md5:149f1b4116e6fa2bccd81c3e5cdf99a6
Message from joachim.metz@gmail.com
2017-04-19T20:37:32+00:00Joachim Metzurn:md5:f4d44b330e659842bced3ab108a62d44
Message from joachim.metz@gmail.com
2017-04-19T20:54:30+00:00Joachim Metzurn:md5:aea0c07ff6a9e5e17a32228c372ca12a
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh
File config/travis/install.sh (right):
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh#newcode25
config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfdatetime;
switch from preset to individual package names.
Message from joachim.metz@gmail.com
2017-04-21T03:43:15+00:00Joachim Metzurn:md5:c877cb1661b2cfd677c711c3533ed01b
Code updated.
Message from joachim.metz@gmail.com
2017-04-21T03:43:47+00:00Joachim Metzurn:md5:c34193b91edfa3eb1303e937f5bd1bde
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh
File config/travis/install.sh (right):
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh#newcode25
config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfdatetime;
On 2017/04/19 20:54:30, Joachim Metz wrote:
> switch from preset to individual package names.
Done.
Message from unknown
2017-04-21T03:56:46+00:00Joachim Metzurn:md5:7df2c7941d5a57ccd67f0470f3ca6577
Message from joachim.metz@gmail.com
2017-04-21T03:56:48+00:00Joachim Metzurn:md5:b112bde2c36dc712940187761aa16280
Code updated.
Message from onager@deerpie.com
2017-04-21T06:49:53+00:00onagerurn:md5:cbe2338cc6d7b45df5d4a53975ba03d7
On 2017/04/21 03:56:48, Joachim Metz wrote:
> Code updated.
LGTM
Message from joachim.metz@gmail.com
2017-04-22T09:55:33+00:00Joachim Metzurn:md5:86039195fe368b2ce64ae50cc2d4c48a
Changes have been merged with master branch. To close the review and clean up the feature branch you can run: python ./utils/review.py close utils