Code review - Issue 2135046: NS-3: Addition of GetRelativeVelocity() method to class MobilityModelhttps://codereview.appspot.com/2011-11-19T13:14:08+00:00rietveld
Message from unknown
2010-09-12T11:58:56+00:00Jens Mittagurn:md5:1f1f73f4fb261643e2208f9750f6de4b
Message from pavel.boyko@gmail.com
2011-02-14T16:10:31+00:00Pavel Boykourn:md5:3772a88ad834067e445d32b4a03f006d
Consider fixing minor comment and push.
http://codereview.appspot.com/2135046/diff/1/src/mobility/mobility-model.h
File src/mobility/mobility-model.h (right):
http://codereview.appspot.com/2135046/diff/1/src/mobility/mobility-model.h#newcode67
src/mobility/mobility-model.h:67: double GetRelativeVelocity (Ptr<const MobilityModel> velocity) const;
I'd suggest to rename to GetRelativeSpeed or return Vector.
Also parameter name "velocity" is not clear, I'd use "other" instead (pleas also fix GetDistanceFrom signature too.)
Message from tommypec@gmail.com
2011-06-18T11:58:20+00:00Tommaso Pecorellaurn:md5:9efef32c17427bcc560e927dee0d01f7
4 months review... we need to speedup the process somewhat.
I do agree with Pavel's comment, "Speed" is more appropriate as "Velocity" is used as a vector already.
Fix those and push.
Tommaso
Message from tommypec@gmail.com
2011-11-19T13:14:08+00:00Tommaso Pecorellaurn:md5:9b39437947a82626384d16a2af634da2
The API has been added to ns-3-dev.
Thus, this "Issue" should be considered fixed and closed.