Code review - Issue 15870044: code review 15870044: go.crypto/ssh: in {Server,Client}Conn, read session ID ...https://codereview.appspot.com/2013-10-25T15:15:46+00:00rietveld
Message from unknown
2013-10-23T06:27:39+00:00hanwen-googleurn:md5:a40c7e07a7af9f736b168999c8c8b99d
Message from unknown
2013-10-23T06:27:46+00:00hanwen-googleurn:md5:9b36431f96e880f1591b6a4b10538182
Message from unknown
2013-10-23T06:28:46+00:00hanwen-googleurn:md5:4cea54c0f3bd927ec8d837cd62e422d4
Message from hanwen@google.com
2013-10-23T06:28:50+00:00hanwen-googleurn:md5:a18a3264bde85d35a7d206ad416d711f
Hello agl1, dfc (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go.crypto
Message from hanwen@google.com
2013-10-23T06:42:08+00:00hanwen-googleurn:md5:3e75a261ca57455874301d500a64e93e
this is a break out of 14494058. Once the rekeying is handled at a lower layer, we don't have kexResult in client.go/server.go, so we should get it from transport.sessionID
Message from dave@cheney.net
2013-10-23T16:00:48+00:00dfcurn:md5:ce967d9cad00ae6c97032ffca5700849
On 2013/10/23 06:42:08, hanwen-google wrote:
> this is a break out of 14494058. Once the rekeying is handled at a lower layer,
> we don't have kexResult in client.go/server.go, so we should get it from
> transport.sessionID
Thanks for splitting this out.
This CL needs a better title, how about
"go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to authenticate"
+agl, I'd like you to review this please.
Message from hanwen@google.com
2013-10-23T17:44:02+00:00hanwen-googleurn:md5:f5cfef53dc74a56e1ed1ec139a6cf43b
Changed to " in {Server,Client}Conn, read session ID from
transport layer." (I try to avoid saying what we don't do in descriptions.)
On Wed, Oct 23, 2013 at 9:00 AM, <dave@cheney.net> wrote:
> On 2013/10/23 06:42:08, hanwen-google wrote:
>>
>> this is a break out of 14494058. Once the rekeying is handled at a
>
> lower layer,
>>
>> we don't have kexResult in client.go/server.go, so we should get it
>
> from
>>
>> transport.sessionID
>
>
> Thanks for splitting this out.
>
> This CL needs a better title, how about
>
> "go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to
> authenticate"
>
> +agl, I'd like you to review this please.
>
> https://codereview.appspot.com/15870044/
--
Han-Wen Nienhuys
Google Munich
hanwen@google.com
Message from unknown
2013-10-24T19:51:33+00:00hanwen-googleurn:md5:90ad391704ba0e3769261d573d916f15
Message from agl@golang.org
2013-10-25T15:15:46+00:00agl1urn:md5:c617bea6d7671b6ab809a14f7c749512
*** Submitted as https://code.google.com/p/go/source/detail?r=be3d052402de&repo=crypto ***
go.crypto/ssh: in {Server,Client}Conn, read session ID from
transport layer.
R=agl, dave
CC=golang-dev
https://codereview.appspot.com/15870044
Committer: Adam Langley <agl@golang.org>