Code review - Issue 14227043: code review 14227043: spec: fix small errorhttps://codereview.appspot.com/2013-10-03T19:46:05+00:00rietveld
Message from unknown
2013-10-01T18:38:31+00:00rhurn:md5:b95eba9ada15e8e301da96385a12fca0
Message from unknown
2013-10-01T18:39:08+00:00rhurn:md5:fc731da5356597a79ed17ae10b5fc0e1
Message from unknown
2013-10-01T18:41:25+00:00rhurn:md5:30d008757d9f3fde9fb6f2a1da64a874
Message from robert.hencke@gmail.com
2013-10-01T18:42:19+00:00rhurn:md5:19b2309ba73e5745508eeb7163c093f9
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go
Message from mirtchovski@gmail.com
2013-10-01T19:13:12+00:00aamurn:md5:177a4f6411b95cbf65f6e8da765b5e38
i think the spaces are intentional. a lot of thought has gone into
indenting the reslicing operator in Go: gofmt will remove spaces
around ":" if both sides are constants ([0:3]) or simple function
calls ([0:len(a)]), but to aid clarity, gofmt will insert spaces
around ":" if there are any arithmetic operations involved. but even
though gofmt will remove spaces if it saw this in real code, it
doesn't touch comments.
Message from robert.hencke@gmail.com
2013-10-03T18:56:32+00:00rhurn:md5:3dc08f903efda499f7bf804ed38e37ca
On 2013/10/01 19:13:12, aam wrote:
> i think the spaces are intentional. a lot of thought has gone into
> indenting the reslicing operator in Go: gofmt will remove spaces
> around ":" if both sides are constants ([0:3]) or simple function
> calls ([0:len(a)]), but to aid clarity, gofmt will insert spaces
> around ":" if there are any arithmetic operations involved. but even
> though gofmt will remove spaces if it saw this in real code, it
> doesn't touch comments.
I'm happy to remove the reformatting from the comments - the primary goal was to add the missing word.
Message from r@golang.org
2013-10-03T18:59:32+00:00rurn:md5:d9bd8dcf5d4e0b3875a2fe37ee21b55f
Please update the CL description when you drop the formatting changes.
Message from unknown
2013-10-03T19:12:34+00:00rhurn:md5:304185b5fb2c8206c3b66624f2cd22d6
Message from unknown
2013-10-03T19:13:13+00:00rhurn:md5:22f3c53cd26dd8554cab7eaa7c6ad4e5
Message from robert.hencke@gmail.com
2013-10-03T19:13:16+00:00rhurn:md5:168096f9e6fcabdb137eaeb82cd010ac
Hello golang-dev@googlegroups.com, mirtchovski@gmail.com, r@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from r@golang.org
2013-10-03T19:45:18+00:00rurn:md5:b09072c8445440c48bff9ffead5900d5
LGTM
Message from r@golang.org
2013-10-03T19:46:05+00:00rurn:md5:197893ec53fc0e4e84d102a23328e222
*** Submitted as https://code.google.com/p/go/source/detail?r=e1ddfa430b58 ***
spec: fix small typo in comment for example
R=golang-dev, mirtchovski, r
CC=golang-dev
https://codereview.appspot.com/14227043
Committer: Rob Pike <r@golang.org>