Code review - Issue 13091045: code review 13091045: text/template: implement comparison of basic typeshttps://codereview.appspot.com/2013-09-04T03:10:33+00:00rietveld
Message from unknown
2013-08-21T01:02:06+00:00rurn:md5:539fd73ce97ba8a230fa1dbdc115380e
Message from r@golang.org
2013-08-21T01:02:15+00:00rurn:md5:19c67c0ecca3aafedf0a829bdb078217
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go/
Message from adg@golang.org
2013-08-21T01:16:53+00:00adgurn:md5:a6263ce5a3309822d2191ea07ce0d232
bad test and corresponding bug
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/exec_test.go
File src/pkg/text/template/exec_test.go (right):
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/exec_test.go#newcode920
src/pkg/text/template/exec_test.go:920: {"gt 1 1", "true", true},
false
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/funcs.go
File src/pkg/text/template/funcs.go (right):
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/funcs.go#newcode286
src/pkg/text/template/funcs.go:286: case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
add a TODO to consider comparisons between int and uint
Message from unknown
2013-08-21T01:19:28+00:00rurn:md5:39cb82a6d778535bc29d7e45b3169223
Message from r@golang.org
2013-08-21T01:19:35+00:00rurn:md5:7ec76729f9e0471ff8178f3f87c95240
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from unknown
2013-08-21T01:20:43+00:00rurn:md5:9dcafec81e4dd8345899c1195982e545
Message from r@golang.org
2013-08-21T01:20:50+00:00rurn:md5:c6bf6dc850d799470618862bf4621ea9
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from unknown
2013-08-21T01:21:13+00:00rurn:md5:7273b5a01f78da358fb43ce612501ae0
Message from r@golang.org
2013-08-21T01:21:22+00:00rurn:md5:5dce84b547962603adb199888e9fb6d1
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from adg@golang.org
2013-08-21T01:24:04+00:00adgurn:md5:7fd1a6107b1a3c2934467120407cdb0b
LGTM
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/doc.go
File src/pkg/text/template/doc.go (right):
https://codereview.appspot.com/13091045/diff/1/src/pkg/text/template/doc.go#newcode309
src/pkg/text/template/doc.go:309: eq
add a blank above
Message from unknown
2013-08-21T01:27:18+00:00rurn:md5:123cf6b0a62d3122718bda538d56c943
Message from r@golang.org
2013-08-21T01:27:35+00:00rurn:md5:7f686fa6fa382c39d2d84d7e547d9de6
*** Submitted as https://code.google.com/p/go/source/detail?r=ddd49fd9241d ***
text/template: implement comparison of basic types
Add eq, lt, etc. to allow one to do simple comparisons.
It's basic types only (booleans, integers, unsigned integers,
floats, complex, string) because that's easy, easy to define,
and covers the great majority of useful cases, while leaving
open the possibility of a more sweeping definition later.
{{if eq .X .Y}}X and Y are equal{{else}}X and Y are unequal{{end}}
R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/13091045
Message from rsc@golang.org
2013-09-03T20:56:46+00:00rscurn:md5:21ebd450c5f757cadfc115943d4a8ab0
eq is much more useful if it can take any number of arguments.
https://groups.google.com/d/msg/golang-nuts/OEdSDgEC7js/iyhU9DW_IKcJ
Message from r@golang.org
2013-09-04T03:10:33+00:00rurn:md5:f9e2d9364c6982bdf31c6c9174bb765e
https://codereview.appspot.com/13509046